Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libutil/ev_zlist: drop unused composite watcher #1493

Merged
merged 1 commit into from Apr 30, 2018

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Apr 30, 2018

Just noticed the ev_zlist composite libev watcher no longer has any users, so let's drop it.

libutil/ev_zlist: drop unused composite watcher
Problem: the ev_zlist composite libev watcher has no users.

Drop it and update unit tests.
@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Apr 30, 2018

Ok, will merge after travis reports.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 30, 2018

Coverage Status

Coverage decreased (-0.05%) to 79.031% when pulling 5f5468c on garlick:drop_ev_zlist into ccc0196 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Apr 30, 2018

Codecov Report

Merging #1493 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1493      +/-   ##
==========================================
- Coverage   78.78%   78.73%   -0.06%     
==========================================
  Files         164      163       -1     
  Lines       30587    30553      -34     
==========================================
- Hits        24098    24055      -43     
- Misses       6489     6498       +9
Impacted Files Coverage Δ
src/broker/module.c 83.79% <0%> (-1.4%) ⬇️
src/broker/content-cache.c 73.43% <0%> (-1.3%) ⬇️
src/common/libflux/rpc.c 93.38% <0%> (-0.83%) ⬇️
src/common/libkvs/treeobj.c 85.14% <0%> (-0.41%) ⬇️
src/cmd/flux-module.c 85.06% <0%> (-0.31%) ⬇️
src/common/libflux/message.c 81.13% <0%> (-0.12%) ⬇️
src/common/libkvs/kvs_watch.c 89.69% <0%> (+0.42%) ⬆️
src/common/libutil/base64.c 95.77% <0%> (+0.7%) ⬆️
src/broker/modservice.c 81.55% <0%> (+0.97%) ⬆️
src/common/libutil/blobref.c 98.61% <0%> (+1.38%) ⬆️

@grondo grondo merged commit ff5f81f into flux-framework:master Apr 30, 2018

3 of 4 checks passed

codecov/project 78.73% (-0.06%) compared to ccc0196
Details
codecov/patch Coverage not affected when comparing ccc0196...5f5468c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.05%) to 79.031%
Details
@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Apr 30, 2018

Thanks.

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

@garlick garlick deleted the garlick:drop_ev_zlist branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.