Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libjsc: fix leaks detected by valgrind #1494

Merged
merged 1 commit into from Apr 30, 2018

Conversation

Projects
None yet
4 participants
@grondo
Copy link
Contributor

grondo commented Apr 30, 2018

Fix a few minor leaks in jstatctl.c found when running valgrind
with flux-sched sched module loaded:

  • get_reserve_jcb and get_submit_jcb: free result of xasprintf()
  • freectx: add missing free() for ctx
libjsc: fix leaks detected by valgrind
Fix a few minor leaks in jstatctl.c found when running valgrind
with flux-sched sched module loaded:

 * get_reserve_jcb and get_submit_jcb: free result of xasprintf().
 * freectx: add missing free() for `ctx`

@grondo grondo force-pushed the grondo:jsc-leaks branch from 6f5f64b to a7db87e Apr 30, 2018

@dongahn

This comment has been minimized.

Copy link
Contributor

dongahn commented Apr 30, 2018

This looks good to me. Thank you for doing this @grondo and your valgrind test will be very helpful to avoid issues like this in the future!

@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Apr 30, 2018

NP @dongahn, and thanks for reviewing!

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 30, 2018

Coverage Status

Coverage decreased (-0.03%) to 79.044% when pulling a7db87e on grondo:jsc-leaks into ff5f81f on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Apr 30, 2018

Looks good!

@garlick garlick merged commit f8eccc5 into flux-framework:master Apr 30, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 79.044%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

@grondo grondo deleted the grondo:jsc-leaks branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.