Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: switch to AX_VALGRIND_H for valgrind.h detection #1502

Merged
merged 2 commits into from May 3, 2018

Conversation

Projects
None yet
4 participants
@grondo
Copy link
Contributor

grondo commented May 3, 2018

Pull in ax_valgrind.m4 recently merged to flux-sched for consistency (and to handle case where valgrind.h wouldn't be properly detected if only available via PKG_CHECK_MODULES)

grondo added some commits May 3, 2018

config: add ax_valgrind.m4
Add AX_VALGRIND_H macro for detection of valgrind.h existence
in one of several circumstances:

 - valgrind.pc pkg-config file found and either valgrind.h or
   valgrind/valgrind.h found
 - no valgrind.pc pkg-config found and either valgrind.h or
   valgrind/valgrind.h found

if any case is found then HAVE_VALGRIND is set along with
HAVE_VALGRIND_VALGRIND_H and/or HAVE_VALGRIND_H depending on
which header file is found.
build: switch to AX_VALGRIND_H to find valgrind.h
Switch to AX_VALGRIND_H macro to find valgrind.h for valgrind wrap
of dlclose symbol in the flux-broker.

Add resulting $(VALGRIND_CFLAGS) to broker build, and fix up use
of HAVE_VALGRIND, HAVE_VALGRIND_H, and HAVE_VALGRIND_VALGRIND_H.

@grondo grondo force-pushed the grondo:ax_valgrind branch from bfe1429 to 77fbc2f May 3, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 3, 2018

Codecov Report

Merging #1502 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1502      +/-   ##
==========================================
- Coverage   78.77%   78.75%   -0.03%     
==========================================
  Files         164      164              
  Lines       30673    30673              
==========================================
- Hits        24164    24157       -7     
- Misses       6509     6516       +7
Impacted Files Coverage Δ
src/broker/broker.c 76.97% <ø> (ø) ⬆️
src/cmd/flux-event.c 69.06% <0%> (-0.72%) ⬇️
src/common/libutil/base64.c 95.07% <0%> (-0.71%) ⬇️
src/bindings/lua/flux-lua.c 81.58% <0%> (-0.69%) ⬇️
src/modules/connector-local/local.c 72.74% <0%> (-0.21%) ⬇️
src/broker/overlay.c 74.44% <0%> (+0.63%) ⬆️
src/common/libflux/response.c 84.55% <0%> (+0.81%) ⬆️
src/common/libflux/keepalive.c 93.33% <0%> (+6.66%) ⬆️
@coveralls

This comment has been minimized.

Copy link

coveralls commented May 3, 2018

Coverage Status

Coverage decreased (-0.02%) to 79.054% when pulling 77fbc2f on grondo:ax_valgrind into 3ac89a8 on flux-framework:master.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented May 3, 2018

Sounds good - thanks!

@garlick garlick merged commit 333c283 into flux-framework:master May 3, 2018

3 of 4 checks passed

codecov/project 78.75% (-0.03%) compared to 3ac89a8
Details
codecov/patch Coverage not affected when comparing 3ac89a8...77fbc2f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 79.054%
Details

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

@grondo grondo deleted the grondo:ax_valgrind branch May 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.