Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop jsc rdl_alloc JSC keys #1509

Merged
merged 2 commits into from May 8, 2018

Conversation

Projects
None yet
4 participants
@dongahn
Copy link
Contributor

dongahn commented May 8, 2018

These keys are no longer used in favor of the "R_lite" key.

Adjust the JSC sharness test and README.md.

Will break flux-sched master until flux-framework/flux-sched#339 is merged.

Issue is discussed at flux-framework/flux-sched#338.

Note that "rdl" key is still kept because there is a chance that it can be used by the scheduler as a stopgap solution to support nested scheduler instantiations.

dongahn added some commits May 8, 2018

jsc: Drop "rdl_alloc" and its sub-keys
These keys are no longer used in favor of the "R_lite" key.

Adjust the JSC tests.

Note that "rdl" key is still kept because there is a chance
that it will be used by the scheduler as a stopgap solution to
support nested scheduler instantiations.
@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented May 8, 2018

Looks good thanks!

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 8, 2018

Coverage Status

Coverage increased (+0.05%) to 79.017% when pulling 89ae9af on dongahn:drop_jsc_keys into 090556f on flux-framework:master.

@grondo grondo merged commit 6939f86 into flux-framework:master May 8, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.05%) to 79.017%
Details
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 8, 2018

Codecov Report

Merging #1509 into master will increase coverage by 0.04%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1509      +/-   ##
==========================================
+ Coverage   78.67%   78.72%   +0.04%     
==========================================
  Files         164      164              
  Lines       30686    30597      -89     
==========================================
- Hits        24142    24087      -55     
+ Misses       6544     6510      -34
Impacted Files Coverage Δ
src/common/libjsc/jstatctl.c 73.66% <ø> (+1.3%) ⬆️
src/common/libflux/keepalive.c 86.66% <0%> (-6.67%) ⬇️
src/common/libutil/blobref.c 97.22% <0%> (-1.39%) ⬇️
src/common/libkvs/kvs_txn.c 74.71% <0%> (-0.57%) ⬇️
src/common/libutil/shortjson.h 91.02% <0%> (-0.44%) ⬇️
src/common/libflux/msg_handler.c 87.36% <0%> (-0.37%) ⬇️
src/common/libflux/message.c 81.13% <0%> (-0.36%) ⬇️
src/common/libflux/request.c 88.46% <0%> (ø) ⬆️
src/modules/kvs/kvs.c 66.03% <0%> (+0.16%) ⬆️
src/cmd/flux-module.c 85.36% <0%> (+0.3%) ⬆️
... and 3 more

@grondo grondo referenced this pull request May 10, 2018

Closed

0.9.0 Release #1479

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.