Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wreck: flush PMI server response before closing zio #1528

Merged
merged 2 commits into from May 17, 2018

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

commented May 17, 2018

Per discussion in #1523, fix corner case if data is buffered and not sent immediately.

Also fix a tiny documentation miss.

chu11 added some commits May 16, 2018

wreck/wrexecd: Flush writer before destroy
Before destroying a zio writer, flush any remaining data
that may be internally buffered.

Fixes #1523
@coveralls

This comment has been minimized.

Copy link

commented May 17, 2018

Coverage Status

Coverage decreased (-0.02%) to 78.858% when pulling 2dcac83 on chu11:issue1523 into 2b1f9c8 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

commented May 17, 2018

Codecov Report

Merging #1528 into master will decrease coverage by 0.02%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master    #1528      +/-   ##
==========================================
- Coverage   78.58%   78.56%   -0.03%     
==========================================
  Files         165      165              
  Lines       30779    30781       +2     
==========================================
- Hits        24188    24183       -5     
- Misses       6591     6598       +7
Impacted Files Coverage Δ
src/modules/wreck/wrexecd.c 74.58% <66.66%> (-0.05%) ⬇️
src/modules/connector-local/local.c 72.95% <0%> (-1.44%) ⬇️
src/common/libflux/future.c 88.98% <0%> (-0.45%) ⬇️
src/common/libflux/message.c 81.05% <0%> (-0.12%) ⬇️
src/broker/modservice.c 80.58% <0%> (+0.97%) ⬆️
src/common/libflux/request.c 89.74% <0%> (+1.28%) ⬆️
src/common/libutil/blobref.c 98.61% <0%> (+1.38%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

commented May 17, 2018

Looks good, thanks!

@garlick garlick changed the title Fix zio / pmi corner case wreck: flush PMI server response before closing zio May 17, 2018

@garlick garlick merged commit 3b62c49 into flux-framework:master May 17, 2018

2 of 4 checks passed

codecov/patch 66.66% of diff hit (target 78.58%)
Details
codecov/project 78.56% (-0.03%) compared to 2b1f9c8
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.02%) to 78.858%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.