Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove last references to json-c, simplify/update README.md #1529

Merged
merged 2 commits into from May 18, 2018

Conversation

Projects
None yet
4 participants
@grondo
Copy link
Contributor

grondo commented May 18, 2018

This PR removes json-c references in README.md and codecov.io and check-code-coverage ignore lists.

While I was in there, I quickly simplified and updated the README.md to modernize it. I probably didn't do a complete job, but didn't want to spend too much time on it presently. If someone else wants to make another/alternate pass, that would be fine with me.

grondo added some commits May 18, 2018

coverage: remove stale references to json-c
Though harmless, remove stale references to json-c library
in code coverage ignore syntax for check-code-coverage and
codecov.yml.
README.md: update and simplify
Simplify the README.md and update flux-core requirements.

Fixes #966
@garlick

This comment has been minimized.

Copy link
Member

garlick commented May 18, 2018

Thanks for tackling the README.md. That needed to be done!

Will merge as soon as travis is done.

@coveralls

This comment has been minimized.

Copy link

coveralls commented May 18, 2018

Coverage Status

Coverage decreased (-0.04%) to 79.064% when pulling e5b8ba6 on grondo:README into 302d9ff on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented May 18, 2018

Codecov Report

Merging #1529 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1529      +/-   ##
==========================================
- Coverage   78.81%   78.77%   -0.04%     
==========================================
  Files         164      164              
  Lines       30308    30308              
==========================================
- Hits        23886    23875      -11     
- Misses       6422     6433      +11
Impacted Files Coverage Δ
src/broker/module.c 83.79% <0%> (-1.4%) ⬇️
src/broker/content-cache.c 73.43% <0%> (-1.3%) ⬇️
src/common/libutil/base64.c 95.07% <0%> (-0.71%) ⬇️
src/common/libflux/future.c 88.98% <0%> (-0.45%) ⬇️
src/common/libkvs/kvs_watch.c 89.69% <0%> (-0.43%) ⬇️
src/cmd/flux-module.c 85.06% <0%> (-0.31%) ⬇️
src/cmd/flux-event.c 77.57% <0%> (ø) ⬆️
src/common/libflux/message.c 81.29% <0%> (ø) ⬆️
src/modules/kvs/kvs.c 66.03% <0%> (+0.16%) ⬆️
src/modules/connector-local/local.c 72.95% <0%> (+0.2%) ⬆️
... and 1 more

@garlick garlick merged commit 18fed52 into flux-framework:master May 18, 2018

3 of 4 checks passed

codecov/project 78.77% (-0.04%) compared to 302d9ff
Details
codecov/patch Coverage not affected when comparing 302d9ff...e5b8ba6
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.04%) to 79.064%
Details

@grondo grondo deleted the grondo:README branch Jul 27, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.