Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/libsubprocess: Fix comment typos #1549

Merged
merged 1 commit into from Jun 21, 2018

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Jun 21, 2018

Just a few comment typos I ran across

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jun 21, 2018

Coverage Status

Coverage decreased (-0.03%) to 79.415% when pulling 7b3f37a on chu11:subprocess_minorfixes into 1a3ff37 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jun 21, 2018

Codecov Report

Merging #1549 into master will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1549      +/-   ##
==========================================
- Coverage   79.14%   79.12%   -0.03%     
==========================================
  Files         169      169              
  Lines       31035    31035              
==========================================
- Hits        24564    24556       -8     
- Misses       6471     6479       +8
Impacted Files Coverage Δ
src/common/libsubprocess/subprocess.c 81.12% <ø> (ø) ⬆️
src/common/libflux/mrpc.c 86.11% <0%> (-1.2%) ⬇️
src/common/libutil/base64.c 95.07% <0%> (-0.71%) ⬇️
src/bindings/lua/flux-lua.c 82.15% <0%> (-0.7%) ⬇️
src/cmd/flux-module.c 85.06% <0%> (-0.31%) ⬇️
src/broker/module.c 83.79% <0%> (-0.28%) ⬇️
src/modules/kvs/kvs.c 65.87% <0%> (-0.17%) ⬇️
src/cmd/flux-event.c 77.57% <0%> (ø) ⬆️
src/modules/connector-local/local.c 72.76% <0%> (+0.2%) ⬆️
src/common/libflux/message.c 81.26% <0%> (+0.47%) ⬆️
... and 2 more
@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Jun 21, 2018

Seems perfectly reasonable.

@grondo grondo merged commit 3b6a456 into flux-framework:master Jun 21, 2018

3 of 4 checks passed

codecov/project 79.12% (-0.03%) compared to 1a3ff37
Details
codecov/patch Coverage not affected when comparing 1a3ff37...7b3f37a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.03%) to 79.415%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.