Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

resource: Add IO_DEVICES to pick up GPUs through hwloc #1561

Merged
merged 1 commit into from Jul 3, 2018

Conversation

Projects
None yet
4 participants
@dongahn
Copy link
Contributor

dongahn commented Jul 3, 2018

This PR makes IO hierarchy visible to the scheduler. The sched-side change is in flux-framework/flux-sched#354.

Because this will generally increase the overhead of resource-hwloc module, I can wrap this with an option if desired. Let me know if that's the case.

@dongahn dongahn force-pushed the dongahn:gpu_from_hwloc branch from 7a7219a to 1a5fa1c Jul 3, 2018

@dongahn dongahn requested review from trws and garlick Jul 3, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 3, 2018

Coverage Status

Coverage decreased (-0.05%) to 79.433% when pulling 1a5fa1c on dongahn:gpu_from_hwloc into e44b40f on flux-framework:master.

@garlick

garlick approved these changes Jul 3, 2018

Copy link
Member

garlick left a comment

Thanks @dongahn. I think this is prob ok to merge. Let's open an issue to revisit adding module options / flux-hwloc command line options to alter the load behavior.

@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Jul 3, 2018

@garlick: that works for me.

@trws: if this is ok, could you merge? Then that will allow for testing my sched PR tested on Travis.

@dongahn

This comment has been minimized.

Copy link
Contributor Author

dongahn commented Jul 3, 2018

Ok I restarted two CI configurations. Seems they hit transient errors.

@trws trws merged commit 32ae147 into flux-framework:master Jul 3, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.05%) to 79.433%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.