Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libpmi: drop PMIX heuristic #1575

Merged
merged 1 commit into from Jul 12, 2018

Conversation

Projects
None yet
4 participants
@garlick
Copy link
Member

garlick commented Jul 12, 2018

Problem: The logic that dlopens libpmix.so, expecting to
find PMI-1 symbols there if PMIX_SERVER_URI is set in
the environment no longer works since PMI-1 symbols
were moved to a separate compatibility library.

On the LSF/jsrun based IBM system where PMIX is the native
PMI, we have requested that IBM supply the libpmi.so compatability
library. Once they do, flux should be able to find it in the
usual way.

Meanwhile delete the PMIX heuristic.

Fixes #918

libpmi: drop PMIX heuristic
Problem: The logic that dlopens libpmix.so, expecting to
find PMI-1 symbols there if PMIX_SERVER_URI is set in
the environment no longer works since PMI-1 symbols
were moved to a separate compatibility library.

On the LSF/jsrun based IBM system where PMIX is the native
PMI, we have requested that IBM supply the libpmi.so compatability
library.  Once they do, flux should be able to find it in the
usual way.

Meanwhile delete the PMIX heuristic.

Fixes #918
@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 12, 2018

Coverage Status

Coverage decreased (-0.006%) to 79.452% when pulling fec0f68 on garlick:drop_pmix_heuristic into 32ae147 on flux-framework:master.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Jul 12, 2018

Looks good, thanks!

@grondo grondo merged commit 18beeb2 into flux-framework:master Jul 12, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.006%) to 79.452%
Details
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 12, 2018

Codecov Report

Merging #1575 into master will decrease coverage by <.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1575      +/-   ##
==========================================
- Coverage   79.16%   79.15%   -0.01%     
==========================================
  Files         170      170              
  Lines       31180    31170      -10     
==========================================
- Hits        24684    24674      -10     
  Misses       6496     6496
Impacted Files Coverage Δ
src/common/libpmi/pmi.c 48.37% <ø> (+1.33%) ⬆️
src/modules/connector-local/local.c 72.76% <0%> (-1.63%) ⬇️
src/common/libflux/mrpc.c 86.11% <0%> (-1.2%) ⬇️
src/common/libkvs/treeobj.c 85.14% <0%> (-0.41%) ⬇️
src/common/libflux/message.c 81.02% <0%> (ø) ⬆️
src/bindings/lua/flux-lua.c 82.23% <0%> (+0.08%) ⬆️
src/cmd/flux-module.c 85.36% <0%> (+0.3%) ⬆️
src/common/libflux/response.c 83.55% <0%> (+0.65%) ⬆️

@garlick garlick deleted the garlick:drop_pmix_heuristic branch Jul 16, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.