Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux_future_get: void * -> const void ** #1611

Merged
merged 1 commit into from Jul 28, 2018

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Jul 27, 2018

Per #1602, replace void * parameter with const void ** parameter, so code is consistent to changes done in #1144 and #1212.

I was in the area of this code in PR #1610 and just decided to fix it. This PR follows PR #1610 and should be merged after it.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jul 27, 2018

Coverage Status

Coverage increased (+0.006%) to 79.527% when pulling 12664e3 on chu11:issue1602 into 90f05e9 on flux-framework:master.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Jul 27, 2018

Codecov Report

Merging #1611 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1611      +/-   ##
==========================================
+ Coverage   79.35%   79.36%   +<.01%     
==========================================
  Files         171      171              
  Lines       31461    31461              
==========================================
+ Hits        24966    24968       +2     
+ Misses       6495     6493       -2
Impacted Files Coverage Δ
src/modules/wreck/job.c 71.12% <100%> (ø) ⬆️
src/common/libflux/composite_future.c 82.63% <100%> (ø) ⬆️
src/common/libflux/future.c 86.2% <100%> (+0.31%) ⬆️
src/common/libflux/rpc.c 93.33% <100%> (ø) ⬆️
src/common/libkvs/kvs_watch.c 90.12% <100%> (ø) ⬆️
src/common/libutil/dirwalk.c 94.28% <0%> (-0.72%) ⬇️
src/broker/overlay.c 73.81% <0%> (-0.32%) ⬇️
src/common/libflux/message.c 80.9% <0%> (-0.12%) ⬇️
src/modules/kvs/kvs.c 66.03% <0%> (+0.16%) ⬆️
... and 2 more
@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Jul 27, 2018

This just needs a rebase after merge of #1610

libflux/future: convert void * to const void **
In flux_future_get, convert void * parameter to void ** parameter,
consistent to fixes done in #1144 and #1212.

Fixes #1602

@chu11 chu11 force-pushed the chu11:issue1602 branch from 5ed0446 to 12664e3 Jul 27, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Jul 27, 2018

rebased

@grondo grondo merged commit 1580764 into flux-framework:master Jul 28, 2018

4 checks passed

codecov/patch 100% of diff hit (target 79.35%)
Details
codecov/project 79.36% (+<.01%) compared to 90f05e9
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.006%) to 79.527%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.