Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/job: Fix fallthrough error case bug #1617

Merged
merged 1 commit into from Aug 15, 2018

Conversation

Projects
None yet
3 participants
@chu11
Copy link
Contributor

chu11 commented Aug 9, 2018

Simple fallthrough bug I found. By not returning on error, the code continued on in the "good path".

@coveralls

This comment has been minimized.

Copy link

coveralls commented Aug 9, 2018

Coverage Status

Coverage increased (+0.02%) to 79.53% when pulling e0dac1a on chu11:jobfallthroughbug into 9095ed9 on flux-framework:master.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Aug 9, 2018

restarted a stalled build

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Aug 15, 2018

That looks pretty obvious. Thanks!

@garlick garlick merged commit 62a8aa5 into flux-framework:master Aug 15, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.02%) to 79.53%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.