Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: small set of travis-ci and test fixes #1644

merged 4 commits into from Sep 4, 2018


None yet
4 participants
Copy link

grondo commented Sep 4, 2018

These are the "other fixes" for the testsuite and travis-ci taken from #1642.

grondo added some commits Aug 31, 2018

travis-ci: add missing CXX override to travis-dep-builder
In, ensure built sources use system C++
compiler not the overridden CXX from the travis build. This
was already done for CC, but not CXX.
travis-ci: export configure args to make distcheck
Problem: The ./configure arguments set for travis were not being
passed through to the underlying `make distcheck`, and were instead
only used on the outer ./configure in preparation for distcheck.

Export DISTCHECK_CONFIGURE_FLAGS=$ARGS so that the same configure
flags are used in `make distcheck` as expected.
t2200-job-ingest.t: fix typo in sign-type check
Fix a typo when the script checks for --sign-type option existence
for `flux job submitbench`. This was causing an erroneous requirement
for a running munge daemon during `make check`.
t2200-job-ingest: fix badowner and badrole tests
The tests for submission with bad signature and bad role in the
job ingest checks were checking for the wrong strings in the
error output. Add the actual expected strings in the check to
avoid these false failures.

@grondo grondo force-pushed the grondo:travis-fixes branch from 403e9d8 to 33c701b Sep 4, 2018


This comment has been minimized.

Copy link
Contributor Author

grondo commented Sep 4, 2018

Rebased on current master


This comment has been minimized.

Copy link

codecov-io commented Sep 4, 2018

Codecov Report

Merging #1644 into master will increase coverage by 0.35%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1644      +/-   ##
+ Coverage   78.97%   79.33%   +0.35%     
  Files         179      179              
  Lines       32535    32535              
+ Hits        25694    25811     +117     
+ Misses       6841     6724     -117
Impacted Files Coverage Δ
src/common/libflux/keepalive.c 86.66% <0%> (-6.67%) ⬇️
src/modules/connector-local/local.c 72.76% <0%> (-1.63%) ⬇️
src/common/libutil/dirwalk.c 93.57% <0%> (-0.72%) ⬇️
src/common/libkvs/kvs_txn.c 74.71% <0%> (-0.57%) ⬇️
src/common/libflux/message.c 80.66% <0%> (-0.36%) ⬇️
src/modules/kvs/kvs.c 65.87% <0%> (-0.17%) ⬇️
src/broker/overlay.c 74.13% <0%> (+0.31%) ⬆️
src/common/libflux/rpc.c 93.49% <0%> (+0.81%) ⬆️
src/broker/modservice.c 81.55% <0%> (+0.97%) ⬆️
src/common/libjobspec/jobspec.cpp 84.21% <0%> (+1.61%) ⬆️
... and 3 more

This comment has been minimized.

Copy link

coveralls commented Sep 4, 2018

Coverage Status

Coverage increased (+0.4%) to 79.516% when pulling 33c701b on grondo:travis-fixes into 05b1961 on flux-framework:master.


This comment has been minimized.

Copy link

garlick commented Sep 4, 2018

Thanks alot for fixing my sloppy mistakes in the ingest test script!

@garlick garlick merged commit b4c64c0 into flux-framework:master Sep 4, 2018

4 checks passed

codecov/patch Coverage not affected when comparing 05b1961...33c701b
codecov/project 79.33% (+0.35%) compared to 05b1961
continuous-integration/travis-ci/pr The Travis CI build passed
coverage/coveralls Coverage increased (+0.4%) to 79.516%

@grondo grondo deleted the grondo:travis-fixes branch Sep 4, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.