Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/subprocess: Do not append _FD to channels #1659

Merged
merged 1 commit into from Sep 13, 2018

Conversation

Projects
None yet
3 participants
@chu11
Copy link
Contributor

chu11 commented Sep 13, 2018

Do not append the string "_FD" to the channel environment variables
created for subprocesses. Instead, use the channel name itself.
If the caller wishes for the environment variable to have "_FD"
at the end, they should name their channel with "_FD" at the end.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Sep 13, 2018

this is per discussion in #1564. Also does not matter order of merging of this vs #1658.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 13, 2018

Coverage Status

Coverage increased (+0.01%) to 79.41% when pulling d8bc18a on chu11:issue1331-envname into 5435246 on flux-framework:master.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Sep 13, 2018

hit a #1641, restart builder

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Sep 13, 2018

Looks good, just needs a rebase since #1658 was merged.

common/subprocess: Do not append _FD to channels
Do not append the string "_FD" to the channel environment variables
created for subprocesses.  Instead, use the channel name itself.
If the caller wishes for the environment variable to have "_FD"
at the end, they should name their channel with "_FD" at the end.

@chu11 chu11 force-pushed the chu11:issue1331-envname branch from 74437cf to d8bc18a Sep 13, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Sep 13, 2018

rebased and re-pushed

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Sep 13, 2018

hit at #1641, restarted builder

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Sep 13, 2018

Thanks!

@grondo grondo merged commit 7c38aa3 into flux-framework:master Sep 13, 2018

2 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.01%) to 79.41%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.