Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename flux_subprocess_output() #1664

Merged
merged 2 commits into from Sep 17, 2018

Conversation

Projects
None yet
3 participants
@chu11
Copy link
Contributor

chu11 commented Sep 14, 2018

Rename flux_subprocess_output() to flux_standard_output(). The prefix flux_subprocess can suggest the function is part of the core subprocess API, but it is simply a convenience function.

Also fix some error message outputs I found.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Sep 15, 2018

Coverage Status

Coverage decreased (-0.003%) to 79.953% when pulling a48619c on chu11:issue1331-renameoutput into 506d305 on flux-framework:master.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Sep 15, 2018

diff target bad, but it's mostly error path misses.

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Sep 17, 2018

This one just needs a rebase.

chu11 added some commits Sep 14, 2018

common/subprocess: Rename flux_subprocess_output
Rename flux_subprocess_output() to flux_standard_output().  The
prefix 'flux_subprocess' can suggest the function is part of the
subprocess API, but it is simply a convenience function.  Also
add some comments clearly indicating it is a convenience function.

@chu11 chu11 force-pushed the chu11:issue1331-renameoutput branch from 83ebbcf to a48619c Sep 17, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Sep 17, 2018

re-pushed

@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Sep 17, 2018

Thanks!

@grondo grondo merged commit 54ce1fb into flux-framework:master Sep 17, 2018

3 of 4 checks passed

codecov/patch 20% of diff hit (target 79.64%)
Details
codecov/project 79.65% (+0.01%) compared to 506d305
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
coverage/coveralls Coverage decreased (-0.003%) to 79.953%
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.