Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KVS: fix memleak path + other random cleanups #1694

Merged
merged 5 commits into from Oct 5, 2018

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Oct 3, 2018

No description provided.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 4, 2018

LGTM!

chu11 added some commits Oct 2, 2018

modules/kvs: Fix memleak on lookup stalls
Fix mem-leak path in which a lookup handle is created but not
destroyed properly when getroot is called on a missing namespace.

Fixes #1690

@chu11 chu11 force-pushed the chu11:issue1690 branch from 783a4db to 4bb44b4 Oct 5, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 5, 2018

rebased on master

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #1694 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1694      +/-   ##
==========================================
- Coverage   79.28%   79.26%   -0.02%     
==========================================
  Files         186      186              
  Lines       35063    35066       +3     
==========================================
- Hits        27798    27795       -3     
- Misses       7265     7271       +6
Impacted Files Coverage Δ
src/modules/kvs/waitqueue.c 84% <ø> (ø) ⬆️
src/modules/kvs/kvs.c 65.95% <100%> (-0.16%) ⬇️
src/modules/connector-local/local.c 73.16% <0%> (-1.36%) ⬇️
src/cmd/flux-module.c 85.28% <0%> (-0.31%) ⬇️
src/common/libflux/message.c 81.3% <0%> (+0.23%) ⬆️
src/common/libflux/mrpc.c 86.64% <0%> (+1.14%) ⬆️

@grondo grondo merged commit a702ecf into flux-framework:master Oct 5, 2018

3 checks passed

codecov/patch 100% of diff hit (target 79.28%)
Details
codecov/project Absolute coverage decreased by -0.01% but relative coverage increased by +20.71% compared to 1c86b38
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo

This comment has been minimized.

Copy link
Contributor

grondo commented Oct 5, 2018

Merged since @garlick gave his ack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.