KVS: refactor kvs lookup replays #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1696 +/- ##
==========================================
- Coverage 79.3% 79.28% -0.02%
==========================================
Files 186 185 -1
Lines 35059 35037 -22
==========================================
- Hits 27804 27780 -24
- Misses 7255 7257 +2
|
Add flux_requeue_nocopy(), equivalent to flux_requeue() but takes ownership of the message passed in by the caller.
Add msg_cb_handler_msg_aux_set() and msg_cb_handler_msg_aux_get() to msg_cb_handler to allow user to set/get aux data to the message stored within the msg cb handler.
Add wait_msg_aux_set() and wait_msg_aux_get() to internal wait_t structure to allow user to set/get aux data to the message stored within a wait_t.
When a lookup request is replayed, instead of passing the lookup handle via the additional 'arg' parameter, pass it via auxiliary data in the rpc message.
On getroot stalls, instead of calling the original callback function directly (via msg_cb_handler), instead simply replay the original message via flux_requeue_nocopy(). Fixes flux-framework#1318
Remove aux data support in a lookup_t during create time and remove lookup_get_aux_data(). aux data in lookup is no longer used.
Refactor waitqueue to internally manage msg callback handler instead of using msg_cb_handler. This commit effectively reverts 0c3dfce
|
rebased on master after the #1694 merge |
|
Nice cleanup! |
|
Hm, your build hit the same hangs as @SteVwonder saw in #1699 at I'll try restarting builders for now, but we may have to reopen #1699 and follow up (now that we know it can be reproduced in a PR I guess) |
|
It seems to have hung again: Time to re-open #1699? |
|
This looks great @chu11! |
|
stephen seems to have his debug logs, so restarting the builder hoping it'll pass this time |
|
looks like it passed this time |
This was referenced Oct 8, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per discussion in #1318, refactor replays of lookups to use flux msg aux instead of rpc
argparameter.This cleans up the code a bit and IMO makes it more clear, but the big win is the removal of the
msg_cb_handlermini-library in the KVS module.This PR follows #1694 and should be merged after it.