Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1701

merged 3 commits into from Oct 5, 2018


None yet
4 participants
Copy link

SteVwonder commented Oct 5, 2018

Updates the, README, and travis builder (which flux-sched still uses) to reflect changes in dependencies.

Closes #1700
Closes #1117
Closes #1271
Closes #1046 (the py3 PR was actually supposed to close this but I accidentally removed the commit when I was squashing)


This comment has been minimized.

Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #1701 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1701      +/-   ##
+ Coverage   79.25%   79.27%   +0.01%     
  Files         185      185              
  Lines       35041    35041              
+ Hits        27773    27779       +6     
+ Misses       7268     7262       -6
Impacted Files Coverage Δ
src/common/libflux/message.c 80.95% <0%> (-0.24%) ⬇️
src/broker/modservice.c 79.8% <0%> (+0.96%) ⬆️
src/modules/connector-local/local.c 74.51% <0%> (+1.35%) ⬆️

This comment has been minimized.

Copy link

garlick commented Oct 5, 2018

This looks fine to me, just needs a rebase.

(optional) it might be nice to split the fix to the m4 to allow quotes to a separate commit.

@SteVwonder SteVwonder force-pushed the SteVwonder:update-dependencies branch from 0d4b002 to f6fb9ff Oct 5, 2018


This comment has been minimized.

Copy link
Member Author

SteVwonder commented Oct 5, 2018


m4 change split out, rebased onto master, and pushed.

SteVwonder added some commits Oct 4, 2018

configure: check python dependencies: pylint and six
- ensure pylint >= 1.4.5
- ensure six >= 1.9.0

Closes #1046
Closes #1700
readme: update listed dependencies
Related to: #1700
Closes: #1117
Closes: #1271
m4: update python module version checking macro
    - support single quotes in configure check code
    - support use of distutils's version objects

Useful for comparing version strings (rather than version

Example usage:
`StrictVersion(mymodule.__version__) >= StrictVersion('1.0.0')`

@SteVwonder SteVwonder force-pushed the SteVwonder:update-dependencies branch from f6fb9ff to 6e75df4 Oct 5, 2018

@grondo grondo merged commit 16840a8 into flux-framework:master Oct 5, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 3802e87...6e75df4
codecov/project 79.27% (+0.01%) compared to 3802e87
continuous-integration/travis-ci/pr The Travis CI build passed

This comment has been minimized.

Copy link

grondo commented Oct 5, 2018

Thanks! Merged.

@SteVwonder SteVwonder deleted the SteVwonder:update-dependencies branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.