Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

testsuite: add timeout to valgrind test, add missing test to EXTRA_DIST #1704

Merged
merged 3 commits into from Oct 7, 2018

Conversation

Projects
None yet
3 participants
@grondo
Copy link
Contributor

grondo commented Oct 5, 2018

As discussed in #1699, this PR adds a timeout to the t5000-valgrind.t test (2 minutes, should be plenty of time I think, but we could make it longer). Also, this PR adds the missing issues test to EXTRA_DIST, and small output fix for docker-run-checks.

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Oct 5, 2018

Looks like one failed on a Travis hiccup so I restarted it:

test . = "../../../../src/common" || test -z "" || rm -f 
make[4]: Leaving directory '/usr/src/flux-core-0.10.0-212-g2bbc9384/_build/sub/src/common'
make[4]: write error: stdout
Makefile:838: recipe for target 'distclean-recursive' failed
make[3]: *** [distclean-recursive] Error 1
make[3]: Leaving directory '/usr/src/flux-core-0.10.0-212-g2bbc9384/_build/sub/src/common'
Makefile:497: recipe for target 'distclean-recursive' failed
make[2]: *** [distclean-recursive] Error 1
make[2]: Leaving directory '/usr/src/flux-core-0.10.0-212-g2bbc9384/_build/sub/src'
Makefile:568: recipe for target 'distclean-recursive' failed
make[1]: *** [distclean-recursive] Error 1
make[1]: Leaving directory '/usr/src/flux-core-0.10.0-212-g2bbc9384/_build/sub'
Makefile:774: recipe for target 'distcheck' failed
make: *** [distcheck] Error 1
docker-run-checks.sh: docker run failed
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 5, 2018

Good catch on the missing EXTRA_DIST!

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 5, 2018

Just needs a rebase.

grondo added some commits Oct 5, 2018

testsuite: add missing issues to EXTRA_DIST
t/issues/t0704-mpirun-rank.sh was missing from EXTRA_DIST, so
was dropped from t4000-issues-test-driver.t after a make dist.
t5000-valgrind.t: add timeout to valgrind test
Problem: valgrind test sporadically hangs.

Add a timeout to the run of valgrind to attempt to turn the hang
into a failure.
travis-ci: always use tty in docker checks
Always pass tty option to docker-run so that color output appears
in travis logs.

@grondo grondo force-pushed the grondo:issue#1699 branch from b263ae2 to 60131e9 Oct 7, 2018

@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Oct 7, 2018

Ok, rebased.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 7, 2018

Restarted builder that failed with

Building image bionic-base for user travis 2000 group=20000.55s
Sending build context to Docker daemon  3.072kB
Step 1/14 : ARG IMAGESRC
 ---> 
Step 2/14 : FROM $IMAGESRC
Get https://registry-1.docker.io/v2/fluxrm/testenv/manifests/bionic-base: received unexpected HTTP status: 503 Service Unavailable
docker-run-checks.sh: docker build failed
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 7, 2018

That's got it, thanks!

@garlick garlick merged commit 7e8da68 into flux-framework:master Oct 7, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented on 60131e9 Oct 11, 2018

This change breaks interactive builds for me. I think the --interactive flag should still be passed through when ${INTERACTIVE} is set. @grondo: does runnning docker-run-check.sh -I still work on your machine? Maybe it is just something with how my docker install is configured.

This comment has been minimized.

Copy link
Contributor Author

grondo replied Oct 12, 2018

Yeah, you are right. This fixes it, sorry!

n-checks.sh
index f3ac673f..050df550 100755
--- a/src/test/docker/docker-run-checks.sh
+++ b/src/test/docker/docker-run-checks.sh
@@ -125,6 +125,7 @@ docker run --rm \
     -e TRAVIS \
     -e TAP_DRIVER_QUIET \
     --tty \
+    ${INTERACTIVE:+--interactive} \
     travis-builder:${IMAGE} \
     ${INTERACTIVE:-./src/test/travis_run.sh ${CONFIGURE_ARGS}} \
     || die "docker run failed"

@grondo grondo deleted the grondo:issue#1699 branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.