Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/libutil: Remove blobref_t type #1705

Merged
merged 1 commit into from Oct 5, 2018

Conversation

Projects
None yet
3 participants
@chu11
Copy link
Contributor

chu11 commented Oct 5, 2018

Per RFC7, typedefs should not point to fixed length arrays. So remove
blobref_t typedef globally. Adjust functions to take a char array
and an array length parameter.

Fixes #1692

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 5, 2018

I know there are a lot of lines of code changes, but after the removal of the blobref_t type, it pretty much boils down to replacing blobref_t ref with char ref[BLOBREF_MAX_STRING_SIZE] everywhere. Any function that takes a blobref_t ref is replaced with a char *ref, int ref_len, and any function call that passed a ref, now passes a ref, sizeof (ref).

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 5, 2018

Codecov Report

Merging #1705 into master will decrease coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1705      +/-   ##
==========================================
- Coverage   79.25%   79.25%   -0.01%     
==========================================
  Files         185      185              
  Lines       35041    35042       +1     
==========================================
- Hits        27773    27772       -1     
- Misses       7268     7270       +2
Impacted Files Coverage Δ
src/modules/kvs/kvs.c 65.84% <100%> (ø) ⬆️
src/modules/content-sqlite/content-sqlite.c 56.35% <100%> (ø) ⬆️
src/common/libutil/blobref.c 98.64% <100%> (+0.01%) ⬆️
src/common/libkvs/treeobj.c 85.37% <100%> (ø) ⬆️
src/modules/kvs/kvsroot.c 71.18% <100%> (ø) ⬆️
src/broker/content-cache.c 73.07% <100%> (ø) ⬆️
src/modules/kvs/kvstxn.c 78.34% <100%> (ø) ⬆️
src/modules/barrier/barrier.c 76.55% <0%> (-2.07%) ⬇️
src/common/libflux/handle.c 83.21% <0%> (-0.47%) ⬇️
src/common/libflux/mrpc.c 86.64% <0%> (+1.14%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 5, 2018

Thanks @chu11 - good cleanup.

common/libutil: Remove blobref_t type
Per RFC7, typedefs should not point to fixed length arrays.  So remove
blobref_t typedef globally.  Adjust functions to take a char array
and an array length parameter.

Fixes #1692

@chu11 chu11 force-pushed the chu11:issue1692 branch from f6259ed to 0c4c1d6 Oct 5, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 5, 2018

rebased on master

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 5, 2018

hit #1699 / #1311 , restarted a builder

@garlick garlick merged commit b08e53a into flux-framework:master Oct 5, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.