Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: remove 'magic' field in a few structures #1712

Merged
merged 2 commits into from Oct 9, 2018

Conversation

Projects
None yet
3 participants
@chu11
Copy link
Contributor

chu11 commented Oct 8, 2018

With #1696 done, the 'magic' field is no longer needed in a few locations. In addition, this fixes #1711.

chu11 added some commits Oct 8, 2018

modules/kvs: Remove lookup_t magic field
With removal of replays via rpc 'arg' parameters in commit
bd6eff8, the magic number
in a lookup_t is no longer necessary.

In addition, this fixes an issue in arm71 where it appears
compiler optimization does not set a negated magic number just
before the structure is freed.

Fixes #1711
modules/kvs: Remove kvs_ctx_t magic field
With removal of replays via rpc 'arg' parameters in commit
bd6eff8, the magic number
in a kvs_ctx_t is no longer necessary.
@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 8, 2018

restarted a builder, hit our old write error friend

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Oct 8, 2018

Not sure if that is the old write error, or a different one. @trws suggested we use output synchronization. I'm going to give it a try as a commit on top of this PR and see how it goes.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 8, 2018

It seems to have hit it again, so perhaps is new.

../../libtool: line 2508: printf: write error: Resource temporarily unavailable
make[4]: write error: stdout
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 9, 2018

Restarted builder that hit the above write error from libtool (maybe that's the same one you reported @chu11).

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 9, 2018

Thanks!

@garlick garlick merged commit 3b1e274 into flux-framework:master Oct 9, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

@chu11 chu11 referenced this pull request Oct 11, 2018

Closed

[asan] test_buffer.t #1719

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.