Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asan] Fix easy address sanitizer issues #1735

Merged
merged 7 commits into from Oct 13, 2018

Conversation

Projects
None yet
2 participants
@chu11
Copy link
Contributor

chu11 commented Oct 12, 2018

This PR fixes a number of the "easier" address sanitizer issues found by @trws. Most of these are lazy not cleaning up properly in unit tests. However, address sanitizer did pick up one real mem-leak in lookup_create()!

Most of the code changes should be obvious. Some of the cleanup in the kvs lookup tests required a wrapper function to wrap code like treeobj_insert_entry (obj, "name", treeobj_create_val (...)), so that the reference created by treeobj_create_val() could be decref-ed after insertion.

chu11 added some commits Oct 12, 2018

modules/kvs/test: Remove strdup mem-leaks
Remove mem-leaks discovered by asan due to double strdup.
modules/kvs/test: properly decref treeobjs
Create treeobj wrapper functions to properly create
treeobj objects, insert them into treeobj entries, then
decref the treeobj objects.
common/libflux/test: Remove post destroy buf tests
Remove tests that test that a destroyed buffer is recognized.  Address
sanitizer sees these tests as use-after-free failures.

Fixes #1719
common/libsubprocess/test: call destory in tests
Properly destroy objects in unit tests to avoid mem-leak errors
in address sanitizer

Fixes #1726
modules/kvs/test: destroy objects in treq tests
Properly destroy objects in unit tests in treq, to avoid errors
from address sanitizer

Fixes #1726
@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 12, 2018

hit another

       python/t0008-jsc.py: PASS: N=4   PASS=4   FAIL=0 SKIP=0 XPASS=0 XFAIL=0

No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received

do we think this is not #1699?

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 13, 2018

Looks good to me. I'll go ahead and merge, thanks!

@garlick garlick merged commit 3d67059 into flux-framework:master Oct 13, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.