Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix memleaks caught by leak sanitizer #1736

Merged
merged 7 commits into from Oct 16, 2018

Conversation

Projects
None yet
3 participants
@SteVwonder
Copy link
Member

SteVwonder commented Oct 13, 2018

Fixes various memory leaks caught by leak sanitizer. Most of the leaks were just in test code, but at least one was in an actual library.

This PR is on top of #1733, so that should go in first before merging this.

@SteVwonder SteVwonder changed the title Fix memleaks asan Fix memleaks caught by leak sanitizer Oct 13, 2018

@SteVwonder SteVwonder force-pushed the SteVwonder:fix-memleaks-asan branch from 8c542d1 to 9125bdc Oct 15, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 15, 2018

Codecov Report

Merging #1736 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1736      +/-   ##
==========================================
+ Coverage   79.32%   79.32%   +<.01%     
==========================================
  Files         184      184              
  Lines       34554    34555       +1     
==========================================
+ Hits        27409    27412       +3     
+ Misses       7145     7143       -2
Impacted Files Coverage Δ
src/common/libpmi/clique.c 100% <100%> (ø) ⬆️
src/common/liboptparse/optparse.c 90.81% <100%> (ø) ⬆️
src/modules/connector-local/local.c 72.97% <0%> (-0.2%) ⬇️
src/cmd/flux-event.c 77.97% <0%> (ø) ⬆️
src/common/libflux/message.c 81.3% <0%> (ø) ⬆️
src/modules/barrier/barrier.c 78.62% <0%> (+2.06%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 15, 2018

LGTM! Needs a rebase now that #1733 went in.

@SteVwonder SteVwonder force-pushed the SteVwonder:fix-memleaks-asan branch from 9125bdc to d94d455 Oct 15, 2018

@SteVwonder

This comment has been minimized.

Copy link
Member Author

SteVwonder commented Oct 15, 2018

Rebased. Just waiting for Travis to go green.

@SteVwonder SteVwonder force-pushed the SteVwonder:fix-memleaks-asan branch from d94d455 to dffd89e Oct 16, 2018

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 16, 2018

Kicked a stuck builder.

@garlick garlick merged commit f252756 into flux-framework:master Oct 16, 2018

3 checks passed

codecov/patch 100% of diff hit (target 79.32%)
Details
codecov/project 79.32% (+<.01%) compared to f1b5f77
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@SteVwonder SteVwonder deleted the SteVwonder:fix-memleaks-asan branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.