Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[asan] fix memory leaks and use-after-free found by address sanitizer #1739

Merged
merged 4 commits into from Oct 16, 2018

Conversation

Projects
None yet
3 participants
@chu11
Copy link
Contributor

chu11 commented Oct 15, 2018

Includes a mem-leak found in kvstxn_append(), as well as lazy not cleaning up properly fixes in tests, and several use after free errors in tests.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 15, 2018

Codecov Report

Merging #1739 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1739      +/-   ##
==========================================
+ Coverage   79.32%   79.33%   +0.01%     
==========================================
  Files         184      184              
  Lines       34552    34554       +2     
==========================================
+ Hits        27407    27413       +6     
+ Misses       7145     7141       -4
Impacted Files Coverage Δ
src/modules/kvs/kvstxn.c 78.42% <100%> (+0.07%) ⬆️
src/modules/kvs/kvs.c 65.97% <0%> (+0.15%) ⬆️
src/cmd/flux-module.c 85.88% <0%> (+0.6%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 16, 2018

Thanks!

@garlick garlick merged commit f1b5f77 into flux-framework:master Oct 16, 2018

3 checks passed

codecov/patch 100% of diff hit (target 79.32%)
Details
codecov/project 79.33% (+0.01%) compared to 74fa7c4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.