Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
deps: switch from lzo to lz4 #1740
This commit switches us from lzo as a vendored dependency to lz4 as an
I thought that could be fixed by just updating to the current upstream, since libmunge is now LGPL, but apparently that's just libmunge and not munged where the base64 files come from. So that begs the question, should we talk with folks about getting those two files LGPLed or switch to using the base64 from libsodium (it has it, and we already depend on it)? Thoughts?
lz4 sounds like a win.
Regarding base64, we were already talking with @dun about the license, although actually, it wouldn't be a bad thing to switch over to the one in libsodium. The API looks more or less similar to the one we are using:
libsodium is only a transitive dependency of flux-core though, which means we would need the "dev" package where we didn't before.
Maybe open an issue on that one? It may be easier to just get the license fixed for now.
@@ Coverage Diff @@ ## master #1740 +/- ## ========================================== - Coverage 79.34% 79.33% -0.02% ========================================== Files 184 184 Lines 34559 34552 -7 ========================================== - Hits 27422 27411 -11 - Misses 7137 7141 +4
Would you mind splitting the removal of libminilzo out of 8961aa9 ?
In general, I think it makes the history easier to deal with when commits that contain substantive changes, like changing the compression alg used in
Oct 19, 2018
Crud, sorry, I saw the lib installed but missed the headers! On October 23, 2018 at 9:58:24 AM PDT, Jim Garlick <email@example.com> wrote: Ooops, should have checked - liblz4-dev is not installed on our rhel7 based clusters. I'll open an issue to get that included in the next update. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub<#1740 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AAoStSdqxxoIF6xnu8BA93HdcgI9pbjFks5un0qHgaJpZM4XieJY>.