Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update python/lua KVS bindings to not use kvs classic functions #1748

Merged
merged 5 commits into from Oct 24, 2018

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Oct 22, 2018

Also fix random trivial things I found along the way.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Oct 22, 2018

Codecov Report

Merging #1748 into master will decrease coverage by 0.03%.
The diff coverage is 15.38%.

@@            Coverage Diff             @@
##           master    #1748      +/-   ##
==========================================
- Coverage   79.62%   79.59%   -0.04%     
==========================================
  Files         185      185              
  Lines       34451    34459       +8     
==========================================
- Hits        27433    27426       -7     
- Misses       7018     7033      +15
Impacted Files Coverage Δ
src/bindings/lua/kvs-lua.c 73.15% <0%> (-3.07%) ⬇️
src/modules/wreck/wrexecd.c 76.1% <66.66%> (-0.13%) ⬇️
src/modules/barrier/barrier.c 76.55% <0%> (-2.07%) ⬇️
src/common/libflux/response.c 79.62% <0%> (-1.24%) ⬇️
src/bindings/lua/flux-lua.c 82.12% <0%> (-0.7%) ⬇️
src/cmd/flux-module.c 85.28% <0%> (-0.31%) ⬇️
src/modules/connector-local/local.c 74.51% <0%> (+1.35%) ⬆️
@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 22, 2018

it appears the trivial cleanups I did are not actually covered by any tests, thus the low diff coverage. Should I just remove the trivial cleanups?

@SteVwonder SteVwonder changed the title update python KVS bindings to not use kvs classic functions update python/lua KVS bindings to not use kvs classic functions Oct 23, 2018

@SteVwonder

This comment has been minimized.

Copy link
Member

SteVwonder commented Oct 23, 2018

Looks like pylint is not happy with some of the changes.

Should I just remove the trivial cleanups?

It seems wrong to me to not include cleanups to appease the coverage tool. I'm OK with the coverage drop, but I'll defer to others on this.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 23, 2018

It seems wrong to me to not include cleanups to appease the coverage tool. I'm OK with the coverage drop, but I'll defer to others on this.

Yeah, I'm with Stevie.

@chu11 chu11 force-pushed the chu11:python_kvs_classic branch from 49035d1 to 95ddec3 Oct 23, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 23, 2018

fixed up pylint issues, already squashed patch since it was simple. Also rebased.

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 23, 2018

LGTM

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 23, 2018

hmmm i guess pylint conventions / warnings also have to be corrected

@chu11 chu11 force-pushed the chu11:python_kvs_classic branch from 95ddec3 to 8869baf Oct 24, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 24, 2018

fixed warnings / convention complaints. Considered using a property decorator for aux_txn in the flux handle, but it became complicated when trying to load the kvs bindings as well as the core bindings in handle.py so just removed the underscore prefix to aux_txn.

@chu11 chu11 force-pushed the chu11:python_kvs_classic branch from 8869baf to e44513e Oct 24, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Oct 24, 2018

oops, pushed the wrong tree, trying again

chu11 added some commits Oct 10, 2018

bindings/python: do not use kvs_classic functions
Remove use of kvs_classic functions and use new KVS api functions.
binding/lua: Correct error message return
Incorrect logic could return error message indicating wrong
function caused error.

@chu11 chu11 force-pushed the chu11:python_kvs_classic branch from e44513e to a05e300 Oct 24, 2018

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Oct 24, 2018

Maybe an ack from @SteVwonder on the python changes and then this can go in?

@SteVwonder SteVwonder merged commit bd23bac into flux-framework:master Oct 24, 2018

1 of 3 checks passed

codecov/patch 15.38% of diff hit (target 79.62%)
Details
codecov/project 79.59% (-0.04%) compared to e4baafb
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.