Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.Sign up
libflux: fix composite future implementation #1791
Unfortunately, the composite future implementation was committed with only sanity unit tests, and as was determined by @garlick in #1750, the current code was broken for use with RPCs (and probably any other real-world usage).
The problem is that current executing context of the future on which the user may call
The "fix" is to be sure to propagate the current context (reactor and flux_t handle, if any) to other composites children or prev/next futures at key points (creation, init callback, and flux_future_continue).
Also, it was apparent that the reference handling for
There's some incremental development on
Finally, it would be nice to flesh out the rest of the tests here (still missing tests for
@@ Coverage Diff @@ ## master #1791 +/- ## ========================================= - Coverage 79.6% 79.6% -0.01% ========================================= Files 186 186 Lines 34560 34563 +3 ========================================= + Hits 27512 27514 +2 - Misses 7048 7049 +1
Nice! Thanks so much for fixing this. I was really perplexed when I tried earlier.
Feel free to squash those test additions into the original commit.
Commit message for 97f5d5b contains a spelling error: becaause
I would vote we get this in ASAP and add more tests later since this is damned useful.