Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/t2010-kvs-snapshot-restore: Add shutdown grace #1812

Merged
merged 1 commit into from Nov 8, 2018

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Nov 8, 2018

Add small increased shutdown grace to test to ensure rc3 runs to
completion.

Fixes #1811

t/t2010-kvs-snapshot-restore: Add shutdown grace
Add small increased shutdown grace to test to ensure rc3 runs to
completion.

Fixes #1811

@chu11 chu11 referenced this pull request Nov 8, 2018

Merged

kvs: cleanups & refactoring #1813

@SteVwonder
Copy link
Member

SteVwonder left a comment

Quick turnaround @chu11! I ran into this about an hour ago, and this fix worked perfectly!

Restarted a few hung builders.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Nov 8, 2018

hmmm, had two tests hang, both after t0009-security.py.

make[3]: Entering directory '/usr/src/t'
  python/t0009-security.py:  PASS: N=2   PASS=2   FAIL=0 SKIP=0 XPASS=0 XFAIL=0
make[3]: Leaving directory '/usr/src/t'
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

and had one valgrind fail.

==539== 6,310,486 (112 direct, 6,310,374 indirect) bytes in 1 blocks are definitely lost in loss record 102 of 102
==539==    at 0x4C31D2F: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==539==    by 0x4E89759: ev_realloc (ev.c:1741)
==539==    by 0x4E8E50F: ev_check_start (ev.c:4689)
==539==    by 0x4E64475: then_context_start (future.c:187)
==539==    by 0x4E64475: flux_future_reset (future.c:358)
==539==    by 0x4E7197A: remote_exec_cb (remote.c:636)
==539==    by 0x4E89582: ev_invoke_pending (ev.c:3314)
==539==    by 0x4E8CB48: ev_run (ev.c:3717)
==539==    by 0x4E59152: flux_reactor_run (reactor.c:139)
==539==    by 0xB7C6791: mod_main (job.c:938)
==539==    by 0x113E20: module_thread (module.c:157)
==539==    by 0x55BD6DA: start_thread (pthread_create.c:463)
==539==    by 0x636488E: clone (clone.S:95)
==539== 
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   match-leak-kinds: definite
   fun:realloc
   fun:ev_realloc
   fun:ev_check_start
   fun:then_context_start
   fun:flux_future_reset
   fun:remote_exec_cb
   fun:ev_invoke_pending
   fun:ev_run
   fun:flux_reactor_run
   fun:mod_main
   fun:module_thread
   fun:start_thread
   fun:clone
}

which I think is #1685 / #1641. Going to restart.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Nov 8, 2018

oh @SteVwonder beat me too it :-)

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 8, 2018

Codecov Report

Merging #1812 into master will increase coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master   #1812      +/-   ##
=========================================
+ Coverage   79.67%   79.7%   +0.02%     
=========================================
  Files         187     187              
  Lines       34575   34575              
=========================================
+ Hits        27549   27559      +10     
+ Misses       7026    7016      -10
Impacted Files Coverage Δ
src/modules/kvs/kvs.c 65.44% <0%> (-0.16%) ⬇️
src/modules/barrier/barrier.c 78.62% <0%> (+2.06%) ⬆️
src/common/libflux/handle.c 86.07% <0%> (+2.08%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Nov 8, 2018

Thanks @chu11 - I should have done this when I added the test.

@garlick garlick merged commit ab9e7d0 into flux-framework:master Nov 8, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 3040798...2fb2929
Details
codecov/project 79.7% (+0.02%) compared to 3040798
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.