Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: cleanups & refactoring #1813

Merged
merged 6 commits into from Nov 8, 2018

Conversation

Projects
None yet
2 participants
@chu11
Copy link
Contributor

chu11 commented Nov 8, 2018

This PR follows #1812.

A bunch of fixes and refactoring. The most major one is the refactoring of kvs.namespace-remove event into the kvs.namespace-remove-<namespace> event, so that subscribers need only subscribe to remove events for the namespaces they are concerned about.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Nov 8, 2018

hmmm one build hung after t0018-jobspec.t. Not sure. Just documenting for now.

make[3]: Entering directory '/usr/src/t'
           t0018-jobspec.t:  PASS: N=47  PASS=47  FAIL=0 SKIP=0 XPASS=0 XFAIL=0
make[3]: Leaving directory '/usr/src/t'
No output has been received in the last 10m0s, this potentially indicates a stalled build or something wrong with the build itself.
Check the details on how to adjust your build configuration on: https://docs.travis-ci.com/user/common-build-problems/#Build-times-out-because-no-output-was-received
The build has been terminated

@chu11 chu11 force-pushed the chu11:kvscleanup12 branch from 62e0dff to a4d4b62 Nov 8, 2018

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Nov 8, 2018

"rename" might be more correct than "refactor" in those last two commit messages.

Rename kvs.namespace-remove to kvs.namespace-removed-

how come past tense?

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Nov 8, 2018

how come past tense?

the event is generated after a remove, so thought the past tense was appropriate, instead of reading something like "kvs.namespace-remove-mynamespace" with the present tense.

In my follow up PR, I added a "kvs.namespace-created-mynamespace" event as well.

chu11 added some commits Nov 7, 2018

modules/kvs-watch: Rename setroot variable names
Change variable names in namspace monitor to reflect that
variables refer specifically to setroot events.
modules/kvs: Refactor namespace_create()
Refactor cleanup path of errors in namespace_create().
modules/kvs: Rename kvs.namespace-remove events
Rename kvs.namespace-remove to kvs.namespace-removed-<namespace>,
so event subscribers need only subscribe to the namespaces they
are interested in.  Adjust code appropriately to subscribe to
specific kvs.namespace-removed-<namespace> events.

@chu11 chu11 force-pushed the chu11:kvscleanup12 branch from a4d4b62 to 40fbe84 Nov 8, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Nov 8, 2018

re-pushed with updated commit messages

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Nov 8, 2018

OK sounds good - thanks!

@garlick garlick merged commit e7a0be0 into flux-framework:master Nov 8, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.