Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libflux: drop reduction code #1844

merged 4 commits into from Nov 19, 2018


None yet
3 participants
Copy link

garlick commented Nov 18, 2018

As noted in #1841, the code in libflux/reduce.[ch] kind of missed the mark as a general purpose reduction helper, and is only used in the broker right now, so in the interest of not publishing a bunch of half baked interfaces in the early days, let's cull this one.

garlick added some commits Nov 18, 2018

libflux/reduce: remove from public API
Problem: the reducion scheme in the Flux API
needs redesign, and only has one user in the broker.

Move to the broker source dir, with unit test,
thus removing it from the public API.

Fixes #1841
build: drop unused $(LIBPMIX) references
Problem: a couple of $(LIBPMIX) references were
left over from a past PMIx experiment.

They serve no purpose - drop them.
build: add for broker and its tests
Problem: broker objects are unnecessarily rebuilt for
unit tests.

Create a noinst library containing all the broker
objects except for the one containing main().
This simplifies the rules for buliding tests also.

This comment has been minimized.

Copy link

codecov-io commented Nov 18, 2018

Codecov Report

Merging #1844 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1844      +/-   ##
+ Coverage   79.85%   79.87%   +0.01%     
  Files         197      197              
  Lines       35310    35314       +4     
+ Hits        28198    28208      +10     
+ Misses       7112     7106       -6
Impacted Files Coverage Δ
src/broker/hello.c 79.46% <ø> (ø) ⬆️
src/broker/reduce.c 75.15% <ø> (ø)
src/broker/service.c 85.54% <0%> (-2.12%) ⬇️
src/broker/attr.c 85.9% <0%> (+0.06%) ⬆️
src/common/libflux/message.c 81.27% <0%> (+0.12%) ⬆️
src/broker/heartbeat.c 86.11% <0%> (+0.19%) ⬆️
src/broker/modservice.c 79.8% <0%> (+0.96%) ⬆️
src/common/libflux/mrpc.c 87.89% <0%> (+1.17%) ⬆️
src/modules/barrier/barrier.c 78.62% <0%> (+2.06%) ⬆️

This comment has been minimized.

Copy link

grondo commented Nov 19, 2018

This seems reasonable. Nice cleanup. Merging.

@grondo grondo merged commit a0b0177 into flux-framework:master Nov 19, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 33f764e...1dae20e
codecov/project 79.87% (+0.01%) compared to 33f764e
continuous-integration/travis-ci/pr The Travis CI build passed

@garlick garlick deleted the garlick:reduce_localize branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.