Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs-watch: Support FLUX_KVS_WATCH_UNIQ #1850

Merged
merged 3 commits into from Nov 20, 2018

Conversation

Projects
None yet
4 participants
@chu11
Copy link
Contributor

chu11 commented Nov 20, 2018

Per #1847. The addition was even more trivial than I had originally suspected.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Nov 20, 2018

Codecov Report

Merging #1850 into master will increase coverage by 0.02%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1850      +/-   ##
==========================================
+ Coverage   79.89%   79.92%   +0.02%     
==========================================
  Files         196      196              
  Lines       35300    35302       +2     
==========================================
+ Hits        28204    28216      +12     
+ Misses       7096     7086      -10
Impacted Files Coverage Δ
src/modules/kvs-watch/kvs-watch.c 76.99% <100%> (+0.76%) ⬆️
src/cmd/flux-kvs.c 83.52% <100%> (+0.03%) ⬆️
src/common/libkvs/kvs_lookup.c 81.87% <100%> (-0.11%) ⬇️
src/broker/modservice.c 78.84% <0%> (-0.97%) ⬇️
src/modules/kvs/kvs.c 65.65% <0%> (-0.16%) ⬇️
src/common/libflux/message.c 81.51% <0%> (-0.13%) ⬇️
src/cmd/flux-event.c 77.97% <0%> (ø) ⬆️
src/modules/connector-local/local.c 74.81% <0%> (+1.18%) ⬆️
src/modules/barrier/barrier.c 78.62% <0%> (+2.06%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Nov 20, 2018

Nice that this is not a lot of code! LGTM.

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Nov 20, 2018

let me do @grondo's little fix and I'll re-push

chu11 added some commits Nov 20, 2018

modules/kvs-watch: Support FLUX_KVS_WATCH_UNIQ
Support new flag that will only send watch responses if the key value
differs from the prior response.

Fixes #1847

@chu11 chu11 force-pushed the chu11:issue1847 branch from d0181c5 to b43e332 Nov 20, 2018

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Nov 20, 2018

Thanks!

@garlick garlick merged commit bb5105d into flux-framework:master Nov 20, 2018

3 checks passed

codecov/patch 100% of diff hit (target 79.89%)
Details
codecov/project 79.92% (+0.02%) compared to 3f6a417
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.