Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: don't install libflux-jobspec.la #1867

Merged
merged 1 commit into from Dec 12, 2018

Conversation

Projects
None yet
3 participants
@garlick
Copy link
Member

garlick commented Dec 12, 2018

Problem: libflux-jobspec.la is installed for public
use, but its interfaces are strictly internal to flux-core
at this time.

Don't build libflux-jobspec.la (the externally installed
dynamic library) and don't install the library, the header,
or the pkg-config file. Do continue to build libjobspec.la
for internal use.

Fixes #1864

@chu11

This comment has been minimized.

Copy link
Contributor

chu11 commented Dec 12, 2018

looks good to me, will hit the button once travis done.

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Dec 12, 2018

Restarted a couple of builders - one failed with a hang after the python tests. The other didn't seem to get started.

@chu11

This comment has been minimized.

Copy link
Contributor

chu11 commented Dec 12, 2018

just needs a rebase

build: don't install libflux-jobspec.la
Problem: libflux-jobspec.la is installed for public
use, but its interfaces are strictly internal to flux-core
at this time.

Don't build libflux-jobspec.la (the externally installed
dynamic library) and don't install the library, the header,
or the pkg-config file.  Do continue to build libjobspec.la
for internal use.

Fixes #1864

@garlick garlick force-pushed the garlick:jobspec_noinst branch from 174b0dc to 344124f Dec 12, 2018

@garlick

This comment has been minimized.

Copy link
Member Author

garlick commented Dec 12, 2018

Rebased.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 12, 2018

Codecov Report

Merging #1867 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1867      +/-   ##
==========================================
- Coverage   80.06%   80.04%   -0.02%     
==========================================
  Files         196      196              
  Lines       34960    34960              
==========================================
- Hits        27990    27984       -6     
- Misses       6970     6976       +6
Impacted Files Coverage Δ
src/modules/barrier/barrier.c 76.55% <0%> (-2.07%) ⬇️
src/common/libflux/message.c 81.27% <0%> (-0.37%) ⬇️

@chu11 chu11 merged commit 41515ad into flux-framework:master Dec 12, 2018

2 of 3 checks passed

codecov/project 80.04% (-0.02%) compared to 02fceb5
Details
codecov/patch Coverage not affected when comparing 02fceb5...344124f
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.