Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs-watch: remove getroot watch functionality #1868

merged 6 commits into from Dec 13, 2018


None yet
3 participants
Copy link

chu11 commented Dec 13, 2018

As discussed in our meeting today. There were no users and no expected future users.

chu11 added some commits Dec 13, 2018

cmd/flux-kvs: Remove --watch from getroot
Remove all --watch options from getroot cmd.

Remove tests in t1006-kvs-getroot.t appropriately.

Move some tests to t1007-kvs-look-watch.t.
common/libkvs: Remove getroot watch functionality
Remove all FLUX_KVS_WATCH functionality from getroot.  Remove
relevant unit tests.  Remove flux_kvs_getroot_cancel() function.
modules/kvs-watch: Remove getroot watch ability
Remove ability to watch for getroot events.  In process of removal,
remove commit_incref() and commit_decref().  Change commit_decref()
calls to commit_destroy().
t/kvs: Move getroot tests
Move getroot tests from t1006-kvs-getroot into t1000-kvs.

This comment has been minimized.

Copy link

codecov-io commented Dec 13, 2018

Codecov Report

Merging #1868 into master will increase coverage by <.01%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##           master    #1868      +/-   ##
+ Coverage   80.05%   80.06%   +<.01%     
  Files         196      196              
  Lines       35105    34992     -113     
- Hits        28104    28016      -88     
+ Misses       7001     6976      -25
Impacted Files Coverage Δ
src/modules/kvs-watch/kvs-watch.c 78.07% <100%> (+2.74%) ⬆️
src/common/libkvs/kvs_getroot.c 86.88% <100%> (-2.45%) ⬇️
src/cmd/flux-kvs.c 83.27% <77.77%> (-0.25%) ⬇️
src/common/libutil/veb.c 94.85% <0%> (-4%) ⬇️
src/modules/connector-local/local.c 73.62% <0%> (-0.15%) ⬇️
src/cmd/flux-event.c 77.97% <0%> (ø) ⬆️

This comment has been minimized.

Copy link

garlick commented Dec 13, 2018

Looks good thanks!

@garlick garlick merged commit d3a10d3 into flux-framework:master Dec 13, 2018

3 checks passed

codecov/patch 85.71% of diff hit (target 80.05%)
codecov/project 80.06% (+<.01%) compared to 43c1c01
continuous-integration/travis-ci/pr The Travis CI build passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.