Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules/kvs-watch: Fix ENOTSUP handling #1873

Merged
merged 1 commit into from Dec 15, 2018

Conversation

Projects
None yet
3 participants
@chu11
Copy link
Contributor

chu11 commented Dec 14, 2018

It occurred to me this morning that ENOTSUP handling in kvs-watch was more complicated than necessary. It was an aha moment after dealing with the getroot removal in #1868

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 14, 2018

Codecov Report

Merging #1873 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #1873      +/-   ##
=========================================
+ Coverage   80.09%   80.1%   +<.01%     
=========================================
  Files         196     196              
  Lines       34992   34984       -8     
=========================================
- Hits        28028   28025       -3     
+ Misses       6964    6959       -5
Impacted Files Coverage Δ
src/modules/kvs-watch/kvs-watch.c 78.35% <100%> (+0.28%) ⬆️
src/common/libflux/handle.c 83.99% <0%> (-0.7%) ⬇️
src/cmd/flux-module.c 83.72% <0%> (-0.24%) ⬇️
src/common/libflux/message.c 81.64% <0%> (+0.12%) ⬆️
src/modules/kvs/kvs.c 66.71% <0%> (+0.14%) ⬆️
src/modules/barrier/barrier.c 78.62% <0%> (+2.06%) ⬆️
modules/kvs-watch: Fix ENOTSUP handling
ENOTSUP handling was more complicated than necessary, remove
unnecessary handling.

@chu11 chu11 force-pushed the chu11:kvs_watch_enotsup branch from 5cf99b8 to ec7eab8 Dec 14, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Dec 14, 2018

rebased

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 15, 2018

Ok, looks reasonable. Thanks.

@garlick garlick merged commit 3ead6b3 into flux-framework:master Dec 15, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.