Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs-watch: Allow cancellation of lookups with only WAITCREATE #1879

Merged
merged 2 commits into from Dec 18, 2018

Conversation

Projects
None yet
3 participants
@chu11
Copy link
Contributor

chu11 commented Dec 18, 2018

nothing too extraordinary here. Fixes #1877

chu11 added some commits Dec 18, 2018

common/libkvs: Support WAITCREATE lookup cancels
Allow lookups with WATCH or WAITCREATE to be canceled.

Fixes #1877

@chu11 chu11 force-pushed the chu11:issue1877 branch from 83786e0 to 1bdf706 Dec 18, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 18, 2018

Codecov Report

Merging #1879 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1879      +/-   ##
==========================================
+ Coverage   80.08%   80.08%   +<.01%     
==========================================
  Files         197      197              
  Lines       35006    35008       +2     
==========================================
+ Hits        28035    28037       +2     
  Misses       6971     6971
Impacted Files Coverage Δ
src/common/libkvs/kvs_lookup.c 82.48% <100%> (+0.2%) ⬆️
src/modules/connector-local/local.c 73.62% <0%> (-0.15%) ⬇️
src/modules/kvs/kvs.c 66.35% <0%> (-0.15%) ⬇️
src/cmd/flux-event.c 77.97% <0%> (ø) ⬆️
src/common/libflux/message.c 81.27% <0%> (ø) ⬆️
src/modules/kvs-watch/kvs-watch.c 78.68% <0%> (+0.22%) ⬆️
src/common/libflux/response.c 82.71% <0%> (+1.23%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 18, 2018

Thanks, this seems pretty straighforward!

@garlick garlick merged commit d462fe4 into flux-framework:master Dec 18, 2018

3 checks passed

codecov/patch 100% of diff hit (target 80.08%)
Details
codecov/project 80.08% (+<.01%) compared to 2159faa
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.