Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/flux-module: Increase width of size field #1883

Merged
merged 1 commit into from Dec 20, 2018

Conversation

Projects
None yet
3 participants
@chu11
Copy link
Contributor

chu11 commented Dec 19, 2018

Increase width of size field when listing modules, to handle modules >= 10 megs in size.

Fixes #1872

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Dec 19, 2018

Example of new output. Note that "Size" in the header is right aligned now.

Module                   Size Digest  Idle  S   Nodeset Service
barrier               1023520 F946D6F    0  S         0 
resource-hwloc        1051176 75F4353    0  S         0 
job                   1093840 4873CBA    0  S         0 
kvs                   1518112 021AADA    0  S         0 
aggregator            1044304 D097560    0  S         0 
userdb                1029440 C03069F    0  S         0 
sched                  476960 786BF5C    0  S         0 
resource             12930824 BCECE4D    0  S         0 
kvs-watch             1254184 2FC2C7D    0  S         0 
cron                  1110064 C079B23    0  S         0 
content-sqlite        1037464 C288BA5    0  S         0 content-backing
connector-local       1070784 A346D78    0  R         0 

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 19, 2018

Codecov Report

Merging #1883 into master will increase coverage by <.01%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1883      +/-   ##
==========================================
+ Coverage    80.1%   80.11%   +<.01%     
==========================================
  Files         197      197              
  Lines       35015    35015              
==========================================
+ Hits        28048    28051       +3     
+ Misses       6967     6964       -3
Impacted Files Coverage Δ
src/cmd/flux-module.c 83.72% <100%> (-0.24%) ⬇️
src/modules/barrier/barrier.c 76.55% <0%> (-2.07%) ⬇️
src/bindings/lua/lua-hostlist/hostlist.c 58.78% <0%> (-0.23%) ⬇️
src/common/libflux/message.c 81.39% <0%> (+0.24%) ⬆️
src/modules/connector-local/local.c 74.81% <0%> (+1.03%) ⬆️
cmd/flux-module: Increase width of size field
Increase width of size field when listing modules, to handle modules
>= 10 megs in size.

Fixes #1872

@chu11 chu11 force-pushed the chu11:issue1872 branch from 7755d37 to ca25324 Dec 20, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Dec 20, 2018

rebased

@garlick garlick merged commit 5e4399c into flux-framework:master Dec 20, 2018

3 checks passed

codecov/patch 100% of diff hit (target 80.1%)
Details
codecov/project 80.11% (+<.01%) compared to 615e493
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.