Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python/makefile.am: remove unused and unrecognized variables #1886

Merged
merged 1 commit into from Dec 21, 2018

Conversation

Projects
None yet
5 participants
@SteVwonder
Copy link
Member

SteVwonder commented Dec 21, 2018

The AM_LIBADD variable is unrecognized by autotools. It can be safely
removed since PYTHON_LDFLAGS are already included in the common_libs
variable, which is in-turn included in the LIBADD of all libraries'.

The _job variables and targets were vestiges from the reduction to a
single shared library in #1795. They are unused and can be safely
removed as well.

Closes #1869

@SteVwonder SteVwonder requested review from chu11 and trws Dec 21, 2018

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 21, 2018

Codecov Report

Merging #1886 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1886      +/-   ##
==========================================
+ Coverage   80.09%   80.11%   +0.01%     
==========================================
  Files         197      197              
  Lines       35017    35017              
==========================================
+ Hits        28048    28055       +7     
+ Misses       6969     6962       -7
Impacted Files Coverage Δ
src/common/libflux/mrpc.c 87.55% <0%> (-1.21%) ⬇️
src/common/libflux/message.c 81.39% <0%> (-0.13%) ⬇️
src/cmd/flux-event.c 77.97% <0%> (ø) ⬆️
src/cmd/flux-module.c 83.96% <0%> (+0.23%) ⬆️
src/common/libutil/veb.c 98.85% <0%> (+0.57%) ⬆️
src/modules/connector-local/local.c 74.66% <0%> (+0.88%) ⬆️
src/modules/barrier/barrier.c 78.62% <0%> (+2.06%) ⬆️
@chu11

chu11 approved these changes Dec 21, 2018

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 21, 2018

Thanks!

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 21, 2018

After #1890 goes in I'll rebase this and either push to @SteVwonder's branch if I'm allowed to do that, or resubmit.

@chu11

This comment has been minimized.

Copy link
Contributor

chu11 commented Dec 21, 2018

before merging, I'd like @trws to approve. To make sure the AM_LIBADD change is ok. B/c it was meant for something according to his comment in #1869.

@trws

trws approved these changes Dec 21, 2018

Copy link
Member

trws left a comment

With the PYTHON_LDFLAGS getting into LIBADD through the common variable, I'm all good with this. Thanks for the cleanup!

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 21, 2018

OK rebasing then. Thanks!

python/makefile.am: remove unused and unrecognized variables
The `AM_LIBADD` variable is unrecognized by autotools.  It can be safely
removed since `PYTHON_LDFLAGS` are already included in the `common_libs`
variable, which is in-turn included in the `LIBADD` of all libraries'.

The _job variables and targets were vestiges from the reduction to a
single shared library in #1795.  They are unused and can be safely
removed as well.

Closes #1869

@garlick garlick force-pushed the SteVwonder:fix-autotools-warnings branch from 6eeace2 to a5b805b Dec 21, 2018

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 21, 2018

Wow it feels so wrong to force push someone else's branch!

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 21, 2018

doh! One builder failed with a spurious valgrind error, but I stupidly pressed the restart all button instead of just that builder.

@chu11

This comment has been minimized.

Copy link
Contributor

chu11 commented Dec 21, 2018

woo-hoo!

@chu11 chu11 merged commit f54fb23 into flux-framework:master Dec 21, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 4e11f28...a5b805b
Details
codecov/project 80.12% (+0.03%) compared to 4e11f28
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@SteVwonder

This comment has been minimized.

Copy link
Member Author

SteVwonder commented Dec 22, 2018

Thanks @garlick for the rebase!

@SteVwonder SteVwonder deleted the SteVwonder:fix-autotools-warnings branch Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.