Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libkvs/watch: add deprecated attr to old API #1890

Merged
merged 1 commit into from Dec 21, 2018

Conversation

Projects
None yet
3 participants
@garlick
Copy link
Member

garlick commented Dec 21, 2018

Problem: we don't want new users of the old KVS
watch API.

Add the deprecated attribute to the old functions,
and add a pointer to the new ones in the header.

Fixes #1851

libkvs/watch: add deprecated attr to old API
Problem: we don't want new users of the old KVS
watch API.

Add the deprecated attribute to the old functions,
and add a pointer to the new ones in the header.

Fixes #1851
@chu11

This comment has been minimized.

Copy link
Contributor

chu11 commented Dec 21, 2018

pretty straight forward, I'll hit the button once travis passes

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 21, 2018

Codecov Report

Merging #1890 into master will increase coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1890      +/-   ##
==========================================
+ Coverage    80.1%   80.12%   +0.02%     
==========================================
  Files         196      196              
  Lines       35001    35001              
==========================================
+ Hits        28036    28043       +7     
+ Misses       6965     6958       -7
Impacted Files Coverage Δ
src/cmd/flux-module.c 83.72% <0%> (-0.24%) ⬇️
src/modules/kvs/kvs.c 66.56% <0%> (-0.15%) ⬇️
src/common/libflux/message.c 81.27% <0%> (-0.13%) ⬇️
src/cmd/flux-event.c 77.97% <0%> (ø) ⬆️
src/modules/connector-local/local.c 74.66% <0%> (+0.88%) ⬆️
src/common/libflux/response.c 82.71% <0%> (+1.23%) ⬆️
src/modules/barrier/barrier.c 78.62% <0%> (+2.06%) ⬆️

@chu11 chu11 merged commit 4e11f28 into flux-framework:master Dec 21, 2018

3 checks passed

codecov/patch Coverage not affected when comparing 4750490...3bafd75
Details
codecov/project 80.12% (+0.01%) compared to 4750490
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@garlick garlick deleted the garlick:kvs_watch_deprecate_only branch Dec 21, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.