Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmd/flux-kvs: Hide watch subcommand #1891

Merged
merged 1 commit into from Dec 21, 2018

Conversation

Projects
None yet
3 participants
@chu11
Copy link
Contributor

chu11 commented Dec 21, 2018

The old watch interface is being deprecated, so similarly hide
the option from flux-kvs help output and remove documentation
of it from the manpage.

Fixes #1888

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 21, 2018

Codecov Report

Merging #1891 into master will increase coverage by 0.02%.
The diff coverage is 0%.

@@            Coverage Diff             @@
##           master    #1891      +/-   ##
==========================================
+ Coverage   80.09%   80.12%   +0.02%     
==========================================
  Files         196      196              
  Lines       35001    35002       +1     
==========================================
+ Hits        28034    28045      +11     
+ Misses       6967     6957      -10
Impacted Files Coverage Δ
src/cmd/flux-kvs.c 83.18% <0%> (-0.1%) ⬇️
src/common/libutil/veb.c 98.28% <0%> (-0.58%) ⬇️
src/modules/kvs/kvs.c 66.71% <0%> (+0.14%) ⬆️
src/modules/connector-local/local.c 74.81% <0%> (+1.03%) ⬆️
src/modules/barrier/barrier.c 78.62% <0%> (+2.06%) ⬆️
@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Dec 21, 2018

hehe 0% of diff coverage ... b/c it's just a change to help output

cmd/flux-kvs: Hide watch subcommand
The old watch interface is being deprecated, so similarly hide
the option from flux-kvs help output and remove documentation
of it from the manpage.

Fixes #1888

@chu11 chu11 force-pushed the chu11:issue1888 branch from 642ea29 to 77fe26a Dec 21, 2018

@chu11

This comment has been minimized.

Copy link
Contributor Author

chu11 commented Dec 21, 2018

rebased

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 21, 2018

Thanks!

@garlick garlick merged commit 56825e3 into flux-framework:master Dec 21, 2018

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.