Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wreck: add new -J, --name=JOBNAME option to flux-wreckrun and submit #1893

Merged
merged 4 commits into from Dec 26, 2018

Conversation

Projects
None yet
3 participants
@grondo
Copy link
Contributor

grondo commented Dec 26, 2018

Add new -J, --name=JOBNAME option to flux-wreckrun and flux-submit. This option simply saves JOBNAME in the kvs for the job, and displays this name instead of argv[0] if it exists in the output of flux wreck ls.

grondo added some commits Dec 21, 2018

wreck: support job names
Add support for --name=STRING in flux-wreckrun and flux-submit.
This places a `.name` key in the kvs which is displayed in `flux-wreck ls`
instead of the COMMAND name.

Fixes #1881
doc/test: update spelling dictionary
Add JOBNAME to spelling dictionary
doc: wreck: document -J, --name option
Document new -J, --name=JOBNAME option for wreckrun and submit.
t2000-wreck: sanity check new --name option
Add a sanity check for operation of the new -J, --name option to
flux-wreckrun flux-submit.
@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 26, 2018

Codecov Report

Merging #1893 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1893      +/-   ##
==========================================
- Coverage   80.14%   80.13%   -0.02%     
==========================================
  Files         196      196              
  Lines       35060    35060              
==========================================
- Hits        28098    28094       -4     
- Misses       6962     6966       +4
Impacted Files Coverage Δ
src/common/libflux/handle.c 83.99% <0%> (-2.79%) ⬇️
src/common/libflux/message.c 81.27% <0%> (-0.13%) ⬇️
src/cmd/flux-event.c 77.97% <0%> (ø) ⬆️
src/modules/connector-local/local.c 74.66% <0%> (+0.88%) ⬆️
src/modules/barrier/barrier.c 78.62% <0%> (+2.06%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 26, 2018

This seems completely straightforward and cool. I'm not sure why codecov is cranky here. It seems like this change should not impact coverage at all...

@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Dec 26, 2018

Well, we haven't set a threshold for coverage change I guess, and codecov is red because the coverage dropped 0.02% which is possibly just noise...

@garlick

This comment has been minimized.

Copy link
Member

garlick commented Dec 26, 2018

Right then, I like it! I did also try it out independently, although all I did was pretty much what your test does.

@garlick garlick merged commit 913c104 into flux-framework:master Dec 26, 2018

2 of 3 checks passed

codecov/project 80.13% (-0.02%) compared to aa972be
Details
codecov/patch Coverage not affected when comparing aa972be...511087c
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Dec 27, 2018

Thanks!

@grondo grondo deleted the grondo:wreck-job-name branch Feb 8, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.