Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wreck: small fixes for nokz job output #1900

Merged
merged 2 commits into from Jan 3, 2019

Conversation

Projects
None yet
2 participants
@grondo
Copy link
Contributor

grondo commented Jan 2, 2019

This PR includes a couple small fixes for wreck jobs with nokz.

  • #1899: fix flux-wreck attach with flux-wreckrun nokz jobs that are complete
  • Save output in kvs with flux-wreckrun for nokz jobs when --detach or --wait-until is used to avoid dropping all output.

grondo added some commits Jan 2, 2019

wreck: don't run reactor for complete jobs in attach
Problem: flux-wreck attach for complete jobs with the "nokz"
option active will hang indefinitely, because there are no events
to wake up the mandatory call into the reactor.

Only call into the reactor for jobs that are not in the complete
state or having pending kz IO.

Fixes #1899
wreck: wreckrun: store output in kvs with nokz if -d or -w
Problem: wreckrun drops all output when run with --detach
or --wait-until when used with "nokz" and without --output and
--error.

As in flux-submit, default to kvs://files.{stdout,stderr} when
wreckrun is used with -o nokz and --detach or --wait-until.
@garlick

This comment has been minimized.

Copy link
Member

garlick commented Jan 3, 2019

LGTM

@garlick garlick merged commit acdd8f1 into flux-framework:master Jan 3, 2019

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo

This comment has been minimized.

Copy link
Contributor Author

grondo commented Jan 3, 2019

Thanks!

@grondo grondo deleted the grondo:issue#1899 branch Jan 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.