Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
configure: enable maintainer-mode by default #1912
This also explains why flux-core wasn't suffering from the same issue as flux-sched, where configure was forced be rerun after
Add "enable" option to AM_MAINTAINER_MODE macro. This enables maintainer-mode by default, but still allows for the use of --disable-maintainer-mode by packagers and users when necessary. (I think this is required for debian packaging for example) Use of AM_MAINTAINER_MODE is now discouraged, and if used at all adding the "enable" option is strongly encouraged, so that the package will build as consistently as possibly by default. See: https://www.gnu.org/software/automake/manual/html_node/maintainer_002dmode.html https://blogs.gnome.org/desrt/2011/09/08/am_maintainer_mode-is-not-cool/ https://autotools.io/automake/maintainer.html
Problem: The autogen.sh script copies aclocal.m4 into config/, assuming it will be found there by Makefiles. However, this is not the case, and when maintainer-mode is enabled, the "missing" aclocal.m4 causes a rebuild and re-run of configure. I'm not sure how to convince automake that aclocal.m4 can be found under config, and since we have to copy it by hand that implies we are probably doing something wrong, so just leave it alone.
It is the suggested use in the second reference above: