Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: clean up travis dockerfile, add README #1914

Merged
merged 3 commits into from Jan 9, 2019

Conversation

@grondo
Copy link
Contributor

commented Jan 9, 2019

This PR removes the dependencies manually added by past PRs to travis/Dockerfile (I've rebuilt fluxrm/testenv:bionic-base and fluxrm/testenv:centos7-base and pushed to Docker Hub).

I've also added a README.md to src/test/docker/ describing the theory behind these Dockerfiles, and the instructions for propagating new dependencies from travis/Dockerfile to the fluxrm/testenv images.

While working on this I found that MPI tests were being skipped in the CentOS builds because mpich-3.0 rpms do not install to any default PATH (they need to be loaded with environment-modules)

grondo added 2 commits Jan 9, 2019
Problem: The CentOS 7 mpich-3.0 package does not install into a usable
location by default, and requires the environment-modules command
'module load mpi' to enable. Since we don't run this anywhere in our
build scripts, the MPI tests were silently being skipped.

In travis_run.sh, source /usr/share/Modules/init/bash if it exists
and attempt to `module load mpi` so that mpicc can be found by
configure.
Dependencies added to travis/Dockerfile have been pushed into the
upstream fluxrm/testenv image, so they can safely be removed.
@grondo grondo force-pushed the grondo:docker-updates branch from d98ca7f to 77e06e1 Jan 9, 2019
Add a README describing the use and maintenance of the Docker
images used in Travis CI.
@grondo grondo force-pushed the grondo:docker-updates branch from 77e06e1 to c63ce3a Jan 9, 2019
@garlick

This comment has been minimized.

Copy link
Member

commented Jan 9, 2019

Nice! Thanks!

@garlick garlick merged commit 8f9cc99 into flux-framework:master Jan 9, 2019
2 of 3 checks passed
2 of 3 checks passed
codecov/project 80.11% (-0.02%) compared to e3c8817
Details
codecov/patch Coverage not affected when comparing e3c8817...c63ce3a
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo grondo deleted the grondo:docker-updates branch Jan 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.