Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

proposal: remove -base from docker image names #1915

Merged
merged 1 commit into from Jan 10, 2019

Conversation

@grondo
Copy link
Contributor

commented Jan 10, 2019

There was unfortunately a mismatch in the naming convention for docker images between flux-core and flux-sched, which required slight differences in the docker deploy stanza in travis (which I missed, resulting in no fluxrm/flux-sched:latest tag pushed.)

To simplify our naming convention, this PR changes the name of the fluxrm/testenv images from bionic-base and centos7-base to simply bionic and centos7. This simplification is propagated to the flux-core docker image repo so that the latest master builds are tagged as fluxrm/flux-core:bionic and fluxrm/flux-core:centos7 (instead of bionic-base-latest and centos7-base-latest). The bionic build on master is still also tagged as fluxrm/flux-core:latest.

After this change I'll have to update flux-sched, but I have to fix the deploy of the :latest tag anyway.

This commit changes the name of the base build environment images
from fluxrm/testenv used by `src/test/docker/docker-run-checks.sh`
from "bionic-base" and "centos7-base" to just simply "bionic" and
"centos7".

To further simplify tag naming, the `-latest` suffix is also dropped
from docker images deployed by travis on master. So the latest
master build on Ubuntu 18.04 will now be named, simply,
`fluxrm/flux-core:bionic`. Docker images deployed by builds of
tagged versions will be available as `fluxrm/flux-core:bionic-vX.Y.Z`
@grondo

This comment has been minimized.

Copy link
Contributor Author

commented Jan 10, 2019

One builder failed the valgrind test, restarting

==960== 6,310,425 (224 direct, 6,310,201 indirect) bytes in 1 blocks are definitely lost in loss record 101 of 101
==960==    at 0x4C31D2F: realloc (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so)
==960==    by 0x4E87D99: ev_realloc (ev.c:1746)
==960==    by 0x4E88384: ev_feed_event (ev.c:2012)
==960==    by 0x4E8B2EF: queue_events (ev.c:2041)
==960==    by 0x4E8B2EF: ev_run (ev.c:3723)
==960==    by 0x4E588D2: flux_reactor_run (reactor.c:126)
==960==    by 0xB7C910F: mod_main (job.c:924)
==960==    by 0x1142EB: module_thread (module.c:144)
==960==    by 0x55BA6DA: start_thread (pthread_create.c:463)
==960==    by 0x636188E: clone (clone.S:95)
==960== 
{
   <insert_a_suppression_name_here>
   Memcheck:Leak
   match-leak-kinds: definite
   fun:realloc
   fun:ev_realloc
   fun:ev_feed_event
   fun:queue_events
   fun:ev_run
   fun:flux_reactor_run
   fun:mod_main
   fun:module_thread
   fun:start_thread
   fun:clone
}
==960== LEAK SUMMARY:
==960==    definitely lost: 224 bytes in 1 blocks
==960==    indirectly lost: 6,310,193 bytes in 96 blocks
==960==      possibly lost: 0 bytes in 0 blocks
==960==    still reachable: 36,321 bytes in 83 blocks
==960==         suppressed: 520 bytes in 2 blocks
==960== Reachable blocks (those to which a pointer was found) are not shown.
==960== To see them, rerun with: --leak-check=full --show-leak-kinds=all
==960== 
==960== For counts of detected and suppressed errors, rerun with: -v
==960== ERROR SUMMARY: 1 errors from 1 contexts (suppressed: 1 from 1)
not ok 1 - valgrind reports no new errors on single broker run

@codecov-io

This comment has been minimized.

Copy link

commented Jan 10, 2019

Codecov Report

Merging #1915 into master will decrease coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1915      +/-   ##
==========================================
- Coverage   80.13%   80.09%   -0.04%     
==========================================
  Files         195      195              
  Lines       35109    35109              
==========================================
- Hits        28134    28120      -14     
- Misses       6975     6989      +14
Impacted Files Coverage Δ
src/common/libflux/handle.c 83.99% <0%> (-2.09%) ⬇️
src/common/libflux/mrpc.c 87.55% <0%> (-1.21%) ⬇️
src/modules/kvs/kvs.c 66.78% <0%> (-0.15%) ⬇️
@garlick garlick merged commit 27ab2fe into flux-framework:master Jan 10, 2019
2 of 3 checks passed
2 of 3 checks passed
codecov/project 80.09% (-0.04%) compared to 8f9cc99
Details
codecov/patch Coverage not affected when comparing 8f9cc99...ba459df
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@grondo grondo deleted the grondo:docker-update-testenv branch Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.