Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libidset: add idset_last() #1928

Merged
merged 2 commits into from Jan 17, 2019

Conversation

@garlick
Copy link
Member

commented Jan 17, 2019

Per request in #1927

garlick added 2 commits Jan 17, 2019
Problem: idset_last() is missing, so iteration is
the only way to find the last id in the set.

Add idset_last(), based on vebpred().

Fixes #1927
@garlick garlick force-pushed the garlick:idset_last branch from e6baa1e to 2b324a6 Jan 17, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Jan 17, 2019

Codecov Report

Merging #1928 into master will increase coverage by 0.04%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #1928      +/-   ##
==========================================
+ Coverage   80.08%   80.12%   +0.04%     
==========================================
  Files         195      195              
  Lines       35080    35087       +7     
==========================================
+ Hits        28095    28115      +20     
+ Misses       6985     6972      -13
Impacted Files Coverage Δ
src/common/libidset/idset.c 95.79% <100%> (+1.15%) ⬆️
src/broker/modservice.c 78.84% <0%> (-0.97%) ⬇️
src/common/libflux/message.c 81.64% <0%> (+0.12%) ⬆️
src/modules/kvs/kvs.c 66.92% <0%> (+0.14%) ⬆️
src/modules/kvs-watch/kvs-watch.c 79.77% <0%> (+0.88%) ⬆️
src/common/libflux/mrpc.c 88.75% <0%> (+1.2%) ⬆️
src/modules/barrier/barrier.c 78.62% <0%> (+2.06%) ⬆️
@grondo

This comment has been minimized.

Copy link
Contributor

commented Jan 17, 2019

Thanks!

@grondo grondo merged commit f88d1cd into flux-framework:master Jan 17, 2019
3 checks passed
3 checks passed
codecov/patch 100% of diff hit (target 80.08%)
Details
codecov/project 80.12% (+0.04%) compared to 111ce4b
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@garlick garlick deleted the garlick:idset_last branch Jan 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.