Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
small valgrind test fixes #1941
This PR makes 2 small improvements to the valgrind sharness test:
This PR will fail until #1940 is addressed.
Problem: The valgrind workoad script does not exit with error if one of the workload scripts gets an error during execution or fails to execute. Emit an error on non-zero exit code from the workload scripts, and ensure that the valgrind test itself fails on error from any script, instead of exiting with success.
@@ Coverage Diff @@ ## master #1941 +/- ## ========================================== + Coverage 80.05% 80.08% +0.02% ========================================== Files 195 195 Lines 35078 35078 ========================================== + Hits 28082 28092 +10 + Misses 6996 6986 -10
Ensure at least some code for rank > 0 is run in the valgrind test by executing multiple brokers instead of just a single broker in t5000-valgrind.t. Default size of test is 2 brokers, may be overidden by VALGRIND_NBROKERS. In the case of running many brokers, the shutdown grace period may need to be increased as well, so allow a VALGRIND_SHUTDOWN_GRACE environment variable to do that (default=16s).
Rebased. I also made a couple other changes & cleanup: