Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: remove namespace prefix support #1943

Merged
merged 11 commits into from Jan 23, 2019

Conversation

@chu11
Copy link
Contributor

commented Jan 22, 2019

part 2 of issue #1860 support, this removes namespace prefix support

@codecov-io

This comment has been minimized.

Copy link

commented Jan 22, 2019

Codecov Report

Merging #1943 into master will decrease coverage by 0.12%.
The diff coverage is 88.88%.

@@            Coverage Diff            @@
##           master   #1943      +/-   ##
=========================================
- Coverage   80.12%     80%   -0.13%     
=========================================
  Files         195     195              
  Lines       35110   34945     -165     
=========================================
- Hits        28133   27956     -177     
- Misses       6977    6989      +12
Impacted Files Coverage Δ
src/common/libkvs/kvs_dir.c 95.49% <ø> (-0.31%) ⬇️
src/common/libkvs/kvs_util.c 100% <ø> (+10%) ⬆️
src/modules/kvs/kvs.c 66.21% <100%> (-0.71%) ⬇️
src/cmd/flux-kvs.c 83.06% <100%> (-0.2%) ⬇️
src/modules/kvs-watch/kvs-watch.c 79.05% <100%> (-0.73%) ⬇️
src/modules/kvs/kvstxn.c 76.82% <100%> (-0.52%) ⬇️
src/modules/kvs/lookup.c 80.24% <71.42%> (-1.97%) ⬇️
src/modules/barrier/barrier.c 76.55% <0%> (-2.07%) ⬇️
src/common/libflux/mrpc.c 87.74% <0%> (-1.19%) ⬇️
src/modules/connector-local/local.c 73.62% <0%> (-1.04%) ⬇️
... and 6 more
@garlick

This comment has been minimized.

Copy link
Member

commented Jan 22, 2019

You win the negative lines of code award @chu11! I didn't appreciate the magnitude of the change, and I feel bad that we didn't spot that this was not a great idea at the beginning :-(

LGTM.

@chu11 chu11 force-pushed the chu11:issue1860_part2 branch from 10b6b9d to 536b0f0 Jan 22, 2019
@chu11

This comment has been minimized.

Copy link
Contributor Author

commented Jan 22, 2019

rebased

chu11 added 11 commits Jan 3, 2019
Remove the ability to specify namespace prefixes on kvs
transactions (i.e. writes).  Remove/update all tests
related to ns prefix support in txns / puts / writes.
Remove kvs-watch ns prefix tests as well.
Remove namespace prefix support on kvs lookups.  Remove / update
appropriate tests.
Do not follow symlinks that have ns prefix support.  Remove / update
all related tests.
@chu11 chu11 force-pushed the chu11:issue1860_part2 branch from 536b0f0 to 0cdbacc Jan 23, 2019
@chu11

This comment has been minimized.

Copy link
Contributor Author

commented Jan 23, 2019

rebased

@garlick garlick merged commit d3ee8a1 into flux-framework:master Jan 23, 2019
3 checks passed
3 checks passed
codecov/patch 88.88% of diff hit (target 80.12%)
Details
codecov/project Absolute coverage decreased by -0.12% but relative coverage increased by +8.76% compared to 9822c63
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.