Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
modules/kvs/kvstxn: Fix mem-leak in kvs merge #1946
In one run hit
which appears to be #1077.
But have never seen
which seems disturbing. But I can't imagine my stupid mem-leak fix here could be the cause of this. If my mem-leak fix were truly horrible, there'd be way more bugs than this one. @grondo, got any idea on this one?
@@ Coverage Diff @@ ## master #1946 +/- ## ========================================== + Coverage 80.03% 80.03% +<.01% ========================================== Files 195 195 Lines 34945 34931 -14 ========================================== - Hits 27968 27957 -11 + Misses 6977 6974 -3
actually hold off on a merge, I realized I could refactor this a tiny bit to prevent unexpected errors from coming up in the future. I can't remember why I decided to make separate
Allow kvstxn_create() to take several NULL pointers, so that kvstxn_create_empty() can be removed.