Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
libsubprocess: fix mem-leak on subprocess server teardown #1956
In the subprocess server, free / destroy message copy via aux free function instead of manually freeing / destroying the message copy.
@@ Coverage Diff @@ ## master #1956 +/- ## ========================================== + Coverage 80.01% 80.06% +0.04% ========================================== Files 195 195 Lines 34931 34948 +17 ========================================== + Hits 27951 27980 +29 + Misses 6980 6968 -12
LGTM. I'll just retry my reproducer...
Looks like subprocesses are SIGKILLed and not waited for. Just spoke with @grondo and this is prob fine for now but later on we might want something like a SIGTERM and wait() with timeout, followed by SIGKILL. We can open an issue for that later though.