Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

common/libkvs: Remove namespace list functions #1965

Merged
merged 1 commit into from Jan 26, 2019

Conversation

@chu11
Copy link
Contributor

commented Jan 26, 2019

Remove namespace list functions, which are used only in the
flux-kvs command and no where else.

Have flux-kvs command call kvs.namespace-list target directly.

Fixes #1960

Remove namespace list functions, which are used only in the
flux-kvs command and no where else.

Have flux-kvs command call kvs.namespace-list target directly.

Fixes #1960
@chu11 chu11 force-pushed the chu11:issue1960 branch from de8c130 to 1894fc8 Jan 26, 2019
@codecov-io

This comment has been minimized.

Copy link

commented Jan 26, 2019

Codecov Report

Merging #1965 into master will increase coverage by <.01%.
The diff coverage is 61.53%.

@@            Coverage Diff             @@
##           master    #1965      +/-   ##
==========================================
+ Coverage   80.03%   80.04%   +<.01%     
==========================================
  Files         195      195              
  Lines       34948    34912      -36     
==========================================
- Hits        27970    27944      -26     
+ Misses       6978     6968      -10
Impacted Files Coverage Δ
src/common/libkvs/kvs.c 90.9% <ø> (+3.78%) ⬆️
src/cmd/flux-kvs.c 82.8% <61.53%> (-0.27%) ⬇️
src/cmd/flux-module.c 83.72% <0%> (-0.24%) ⬇️
src/common/libflux/message.c 81.51% <0%> (ø) ⬆️
src/modules/connector-local/local.c 74.81% <0%> (+1.03%) ⬆️
@garlick

This comment has been minimized.

Copy link
Member

commented Jan 26, 2019

This simplifies things. Thanks!

@garlick garlick merged commit 8131f55 into flux-framework:master Jan 26, 2019
2 of 3 checks passed
2 of 3 checks passed
codecov/patch 61.53% of diff hit (target 80.03%)
Details
codecov/project 80.04% (+<.01%) compared to 5d0a7a5
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.