Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kvs: Rename 'namespace' variable globally #1966

Merged
merged 1 commit into from Jan 28, 2019

Conversation

@chu11
Copy link
Contributor

commented Jan 28, 2019

The keyword 'namespace' is a reserved word in C++, so globally
remove use of the variable name 'namespace'.

Generally speaking, all local variables and function parameters
that were 'namespace' are now 'ns'. In a few locations that
'namespace' was previously changed to 'name_space', use 'ns'
instead.

Structs that stored a namespace name now use the variable 'ns_name'.

In kvs-watch, rename 'struct namespace' to 'struct ns_monitor', and
use the variable 'nsm' for that struct.

Fixes #1963

The keyword 'namespace' is a reserved word in C++, so globally
remove use of the variable name 'namespace'.

Generally speaking, all local variables and function parameters
that were 'namespace' are now 'ns'.  In a few locations that
'namespace' was previously changed to 'name_space', use 'ns'
instead.

Structs that stored a namespace name now use the variable 'ns_name'.

In kvs-watch, rename 'struct namespace' to 'struct ns_monitor', and
use the variable 'nsm' for that struct.

Fixes #1963
@codecov-io

This comment has been minimized.

Copy link

commented Jan 28, 2019

Codecov Report

Merging #1966 into master will increase coverage by <.01%.
The diff coverage is 90.51%.

@@            Coverage Diff            @@
##           master   #1966      +/-   ##
=========================================
+ Coverage      80%     80%   +<.01%     
=========================================
  Files         195     195              
  Lines       34912   34913       +1     
=========================================
+ Hits        27931   27933       +2     
+ Misses       6981    6980       -1
Impacted Files Coverage Δ
src/modules/kvs/lookup.c 80.24% <100%> (ø) ⬆️
src/common/libkvs/kvs_watch.c 89.15% <100%> (ø) ⬆️
src/common/libkvs/kvs_getroot.c 86.66% <100%> (ø) ⬆️
src/common/libkvs/kvs_lookup.c 80.76% <100%> (ø) ⬆️
src/cmd/flux-kvs.c 82.8% <100%> (ø) ⬆️
src/common/libkvs/kvs_commit.c 70% <100%> (ø) ⬆️
src/common/libkvs/kvs.c 90.9% <100%> (ø) ⬆️
src/modules/kvs/kvstxn.c 77.15% <100%> (ø) ⬆️
src/modules/kvs/kvsroot.c 71.66% <87.5%> (ø) ⬆️
src/modules/kvs-watch/kvs-watch.c 79.1% <88.88%> (+0.04%) ⬆️
... and 2 more
@garlick

This comment has been minimized.

Copy link
Member

commented Jan 28, 2019

Thanks!

@garlick garlick merged commit 4f7a31c into flux-framework:master Jan 28, 2019
3 checks passed
3 checks passed
codecov/patch 90.51% of diff hit (target 80%)
Details
codecov/project 80% (+<.01%) compared to 8131f55
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.